Hi Raoul, On Fri, Aug 05, 2011 at 09:02:47PM +0200, Raoul Borenius wrote: > On Sun, Jul 10, 2011 at 10:01:19PM +0100, Michael Tautschnig wrote: [...] > > Two further nice-to-have changes: Use dh 7 simplified debian/rules; this would > > immediately address the first two lintian warnings. Moving debian/copyright to > > DEP-5 could go along with the fix of the error reported by lintian. > > I ran into bug 631674 ;-) > > I'll move it to DEP-5 when upstream provides a license file. For the moment > I've included my email-exchange with upstream regarding the missing license in > debian/copyright. I hope that is ok... Regarding #631674 I don't see where this would stop you from converting debian/copyright to DEP-5. Yet the more important part is that you do not provide a verbatim copy of the GPL-3 in debian/copyright for the Debian packaging. Please make sure it's added. Moreover you seem to have skipped at least: ./mgen/protolib/src/sim/ns/ns233/cmu-trace.cc: BSD (4 clause) ./mgen/protolib/src/sim/ns/ns233/cmu-trace.h: BSD (4 clause) ./mgen/protolib/src/sim/ns/ns233/priqueue.cc: BSD (4 clause) ./mgen/protolib/src/sim/ns/ns233/packet.h: BSD (4 clause) ./mgen/protolib/src/sim/ns/ns233/packet.cc: BSD (4 clause) Please review again all files (especially regarding binary files) that they are covered correct in terms of copyright and licensing. If possible, binary files should not be in the source tarball at all as they are very difficult to track licensewise and especially seeing the binary of library and application I'm even more worried that this will end up in the package without recompiling one day. Please make sure the clean target *always* purges these unconditionally whenever they are rebuilt from source (of course database files, images and other binary data like music files are not to be deleted as they usually are not rebuilt from source). Regarding this upstream license you received by email I wonder whether the third paragraph is entirely DFSG-free. Have you asked for recommendations at debian-legal? Or is this license already used by any other package in Debian? In mgen.docs you further use debian/tmp/usr/share/doc/mgen/changelog which shouldn't be a doc, but which should rather passed to dh_installchangelogs if even passing that as argument is required. Most default locations will be caught without problems even if not given as arg to dh_installchangelogs. What puzzles me though is: kk@debian:~/src/debian/build-area/mgen-5.02$ find -iname changelog ./debian/changelog kk@debian:~/src/debian/build-area/mgen-5.02$ There is no upstream changelog in the original tarball?! Are you trying to install the debian/changelog twice? The debian/rules still has the dh-make template header. That can be removed. Just like unused targets (like configure, configure-stamp). I'll refrain Michael's comment that dh 7 style would make this shorter and thus more straightforward (also IMHO). And since you are scripting the install target yourself in debian/rules, why still use debian/tmp as intermediate instead of directly installing into the package directories? Your upstream tarball doesn't match http://downloads.pf.itd.nrl.navy.mil/mgen/src-mgen-5.02.tar.gz which is where your debian/watch would fetch it. Rebuilding your package with that tarball works ok but produces: P: mgen source: source-contains-prebuilt-binary mgen/makefiles/mpmgr P: mgen source: source-contains-prebuilt-binary mgen/makefiles/mgen To fix this you'll either need a new release without prebuilt binaries or you'll have to repack as ~dfsg. Sorry! -- Best regards, Kilian
Attachment:
signature.asc
Description: Digital signature