Re: RFS: mosquitto

[Roger Light <roger@atchoo.org>]

Hi Michael,

Thanks for responding - you've worked up quite a list of reviews there!

On Sun, May 1, 2011 at 5:54 PM, Michael Tautschnig <mt@debian.org> wrote:
> Hi,
>
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "mosquitto".
>>
>> * Package name    : mosquitto
>>  Version         : 0.9.2-1
>>  Upstream Author : Roger Light <roger@atchoo.org>
>> * URL             : http://mosquitto.org/
>> * License         : BSD
>>  Section         : net
>>
> [...]
>
> I've reviewed your package and a few issues need fixing. As you are upstream,
> all of them should be easy to address:
>
> - src/conf.c lacks copyright and license information

This was fixed in 0.10.

> - debian/mosquitto.prerm: Where does the "service" command come from in "service mosquitto stop"?

It comes from sysvinit-utils. I'd like some advice on this topic
though - I've seen both "service" and invoke-rc.d used for
starting/stopping services in prerm. Is there a recommended way of
doing it?

> - 0.10 has been released :-) (according to debian/watch)

Yup - proves that debian/watch works :)

Thanks,

Roger