Re: RFS: liblastfm (new upstream version)
I don't intend to sponsor this package, but here is a review:
You may want to run wrap-and-sort -s
You might want to switch to debhelper 7 dh rules.tiny style.
demos/demo*.cpp and parts of tests/ are in the public domain, but
debian/copyright does not document that.
Why is there a .qmake.cache file?
/me sighs at more code copies of hash algorithms
The upstream README contains dependency and build/install info. You
might want to get upstream to split that into a README.install file.
You may want to add a .symbols file to allow generating more flexible
version deps for programs depending on liblastfm.
There are some gcc warnings you may want to forward upstream.
There are some issues found by cppcheck.
lintian:
I: liblastfm source: binary-control-field-duplicates-source field
"section" in package liblastfm0
I: liblastfm source: binary-control-field-duplicates-source field
"section" in package liblastfm-fingerprint0
I: liblastfm source: debian-watch-file-is-missing
P: liblastfm0: no-upstream-changelog
P: liblastfm0: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
I: liblastfm0: no-symbols-control-file
usr/lib/x86_64-linux-gnu/liblastfm.so.0.3.3
P: liblastfm-dev: no-upstream-changelog
P: liblastfm-dev: copyright-refers-to-symlink-license
usr/share/common-licenses/GPL
P: liblastfm-dbg: no-upstream-changelog
P: liblastfm-dbg: copyright-refers-to-symlink-license
usr/share/common-licenses/GPL
P: liblastfm-fingerprint0: no-upstream-changelog
P: liblastfm-fingerprint0: copyright-refers-to-symlink-license
usr/share/common-licenses/GPL
I: liblastfm-fingerprint0: no-symbols-control-file
usr/lib/x86_64-linux-gnu/liblastfm_fingerprint.so.0.3.3
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: