[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: anox


Thank you for your interest.

>  - It's hardcoded to use "xinit -- :1 vt8".

I do not understand why this is a problem, the eight terminal should
just be free (it's more a limitation than a bug).

>  - It uses /tmp in an unsafe way (eg. predictable filename).  Please use
>   one of the methods Python provides for creating temporary files.

I can do that.

>  - It probably does not handle whitespace in command names or
>   directories.

It handles complex command without problem.

>  - From the documentation on Popen.wait[1]:
>   "Warning: This will deadlock when using stdout=PIPE and/or
>   stderr=PIPE and the child process generates enough output to a pipe
>   such that it blocks waiting for the OS pipe buffer to accept more
>   data."

Ok, I'm not sure to understand how to write the code, but I'll check that point.

>  - The package does not depend on anything providing ck-launch-session.

I should solve that.


Reply to: