[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: dwm (Adapted package)



On Fri, Nov 11, 2011 at 10:15, Vasudev Kamath <kamathvasudev@gmail.com> wrote:
> We can provide different alternative dwm package with different
> config.h file there has been discussion on this [1] [2]. But I think
> after this I think first maintainer Orphaned this package.
>
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493819
> [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=557429

I am not a possible sponsor (no-D{D,M} sorry) and i haven't
even reviewed your package closely, but i am relatively sure
your package doesn't honor buildflags ala CFLAGS correctly.
See dpkg-buildflags manpage, bits from dpkg [0] and some of
the recent discussions here.
(You will properly need to patch upstream Makefile through,
 upstream is properly not that interested in this usecase…)

But to be not completely useless with this mail, let me
attach a patch for the initial issue reported in #493819.
(I uses this for a while for my local dwm package)
Fixing this would allow me to use the pristine dwm package
again (plus a few configs for my various target system).

Thanks for reviving the dwm packaging and
good luck finding a sponsor!


Best regards

David Kalnischkies

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

P.S.: No pun intended with the patch name ;)
--- rules.orig	2011-11-20 14:38:31.698784367 +0100
+++ rules	2011-11-20 14:40:55.704777873 +0100
@@ -16,15 +16,15 @@
 	ln -s dwm.1.gz debian/dwm/usr/share/man/man1/dwm.default.1.gz
 
 	# Building alternatives
-	for ALTERNATIVE in debian/local/config.*; \
+	for ALTERNATIVE in debian/local/config.*.h; \
 	do \
 		$(MAKE) clean; \
 		cp $${ALTERNATIVE} config.h; \
 		CFLAGS="$(CFLAGS)" $(MAKE) PREFIX=/usr; \
-		install -m 0755 dwm debian/dwm/usr/bin/dwm.`basename $${ALTERNATIVE} | sed -e 's|config.||' -e 's|.h||'`; \
-		ln -s dwm.1.gz debian/dwm/usr/share/man/man1/dwm.`basename $${ALTERNATIVE} | sed -e 's|config.||' -e 's|.h||'`.1.gz; \
+		install -m 0755 dwm debian/dwm/usr/bin/dwm.`basename $${ALTERNATIVE} | cut -d'.' -f 2`; \
+		ln -s dwm.1.gz debian/dwm/usr/share/man/man1/dwm.`basename $${ALTERNATIVE} | cut -d'.' -f 2`.1.gz; \
 	done
 
 	# Configuring maintainer scripts
-	sed -e 's|@ALTERNATIVES@|web|' debian/dwm.postinst.in > debian/dwm.postinst
-	sed -e 's|@ALTERNATIVES@|web|' debian/dwm.prerm.in > debian/dwm.prerm
+	sed -e "s|@ALTERNATIVES@|$(shell find debian/local/ -name 'config.*.h' | cut -d'.' -f 2 | tr '\n' ' ')|" debian/dwm.postinst.in > debian/dwm.postinst
+	sed -e "s|@ALTERNATIVES@|$(shell find debian/local/ -name 'config.*.h' | cut -d'.' -f 2 | tr '\n' ' ')|" debian/dwm.prerm.in > debian/dwm.prerm

Reply to: