[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gogglesmm


On Wed, 13 Jul 2011 23:28:28 +0100
Michael Tautschnig <mt@debian.org> wrote:

> [...]
> I'm afraid the copyright file isn't yet fully complete:
> - src/md5.h, src/md5.cpp have a distinct license and copyright holders.
> - src/GMDBus.h is LGPL v2.1+
> - line 11 of debian/copyright should probably say "LGPL", not GPL.

Should now contain the right information.

> A few more minor notes:
> - debian/rules, target clean depends on itself!?

This was left from using dpatch. Originally clean1 depended on clean.

> - lintian has a few more notes, all of which are easy to fix:
> I: gogglesmm source: quilt-patch-missing-description fox_pkg_config.diff
> I: gogglesmm source: debian-watch-contains-dh_make-template
> I: gogglesmm: package-contains-empty-directory usr/sbin/
> I: gogglesmm: desktop-entry-contains-encoding-key usr/share/applications/gogglesmm.desktop:2 Encoding
> [...]

I fixed these warnings.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/g/gogglesmm
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.2-9.dsc

Again, thank you for your review.



Hendrik Rittich

Attachment: signature.asc
Description: PGP signature

Reply to: