Re: RFS: cityhash - family of non-cryptographic hash functions for strings
Hi,
On Thu, Jun 09, 2011 at 07:01:08PM +0200, Jakub Wilk wrote:
> * Alessandro Ghedini <al3xbio@gmail.com>, 2011-06-02, 15:57:
> >http://mentors.debian.net/debian/pool/main/c/cityhash/cityhash_1.0.2-1.dsc
>
> I saw this in city.h:
>
> | typedef uint8_t uint8;
> | typedef uint32_t uint32;
> | typedef uint64_t uint64;
> | typedef std::pair<uint64, uint64> uint128;
> |
> | inline uint64 Uint128Low64(const uint128& x) { return x.first; }
> | inline uint64 Uint128High64(const uint128& x) { return x.second; }
>
> It is not acceptable to define such a generic names in a public
> header. Please educate your upstream not to do that.
I don't quite understand. Of course they may have just avoided those
typedefs in the first place but, no one forces you to include that header
if you don't find it appropriate. Anyway, I'm going to open a ticket upstream.
Cheers
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
Reply to: