[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: cityhash - family of non-cryptographic hash functions for strings

* Alessandro Ghedini <al3xbio@gmail.com>, 2011-06-02, 15:57:

I saw this in city.h:

| typedef uint8_t uint8;
| typedef uint32_t uint32;
| typedef uint64_t uint64;
| typedef std::pair<uint64, uint64> uint128;
| inline uint64 Uint128Low64(const uint128& x) { return x.first; }
| inline uint64 Uint128High64(const uint128& x) { return x.second; }

It is not acceptable to define such a generic names in a public header. Please educate your upstream not to do that.

Jakub Wilk

Reply to: