[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: downtimed



Hi Mats,

On Dienstag, 8. Februar 2011, Mats Erik Andersson wrote:
> http://mentors.debian.net/debian/pool/main/d/downtimed/downtimed_0.4-1.dsc

my comments:

- you have a build-dep on debhelper (>= 7.0.50~), which is not in the archive. 
I assume this is intentional?!

- did you send your three patches upstream?

- "# Do we want to go? " is strange english (says the German..) 
in /etc/defaul/downtimed, I would probably just shorten the whole line to '# 
Set to "Yes" or "yes" or not.'  :-)

- the initscript could maybe go with a copyright header...

- nice work!

Do you want to correct some things or should I upload?


cheers,
	Holger

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: