Hi, Il giorno sab, 22/01/2011 alle 18.28 +0100, Mònica Ramírez Arceda ha scritto: > Hi, > > El dv 21 de 01 de 2011 a les 18:30 +0100, en/na Fabrizio Regalli va > escriure: > > Dear mentors, > > > > I am looking for a sponsor for my package "piwik". > > > > * Package name : piwik > > Version : 1.1.1-1 > > Upstream Author : Fabrizio Regalli <fabreg@fabreg.it> > > * URL : http://www.piwik.org > > * License : GPL v3 > > Section : web > > > > It builds these binary packages: > > piwik - Open source web analytics > > I am not a DD, so I can't upload your package, but I've taken a quick > look to it. > Thank you. > > The package appears to be lintian clean. > > * There're some lintian messages that maybe you can solve: > > I: piwik source: debian-watch-file-is-missing > I: piwik: extended-description-is-probably-too-short > P: piwik: no-upstream-changelog > W: piwik: executable-not-elf-or-script ./usr/share/piwik/plugins/UserSettings/images/os/WP7.gif > W: piwik: executable-not-elf-or-script ./usr/share/piwik/plugins/UserSettings/images/os/W61.gif > W: piwik: executable-not-elf-or-script ./usr/share/piwik/plugins/UserSettings/images/os/W65.gif > W: piwik: executable-not-elf-or-script ./usr/share/piwik/plugins/UserSettings/images/os/MAE.gif > O: piwik: embedded-php-library usr/share/piwik/libs/Smarty/Smarty.class.php > O: piwik: embedded-php-library usr/share/piwik/libs/Smarty/Smarty_Compiler.class.php > I: piwik: package-contains-empty-directory usr/share/piwik/libs/Zend/Feed/Pubsubhubbub/Http/ > I: piwik: package-contains-empty-directory usr/share/piwik/tmp/ Locally, on my workstation, I see only the two "O:" for overraiding The W: is related to the wrong permission files on the source. I fix it again. > > * lintian overrides: Your comment says > > # The smarty lib is also modified. We will use the one provided by the package > > I think it's not a good idea to have duplicated libraries because of > security issues. But if you need to change the library source code, > maybe there is a better way to do it. Someone else knows what to do in > these cases? > Ok, I'm waiting for a DD answer. > * debian/install: some lines have absolute path and others relative > path. Absolute paths are wrong: you should convert absolute paths to > relative. > Fixed in new upload. > * you get the patch debian/patches/debian-changes-1.1.1-1 because you've > included two files in config/ of upstream. You also have these files in > debian/conf. I don't understand this duplication. > Fixed in new upload. > If the patch is necessary, you should comment the header of this patch, > and maybe rename it with a suitable name. > > * debian/rules: you sholudn't indent your comments if you don't want to > be verbose during building. > Fixed in new upload. > * postinst/postrm: indent left first level "if"'s. Fixed in new upload. > > * debian/LICENSE: where do you use this file? This file is a part of the origial package. > > * README and debian/README.Debian are the same file. You can remove > debian/README.Debian because it says nothing relevant to Debian. Not exactly: are quite similar but not the same. In README.Debian there is a configuration part related to mysql. > > I haven't tested the application and I think a deeper review is needed > by a developer with more experience than me (and a review of my review > is also appreciated!). I've tested on my machine, locally, and I haven't problem. > > I hope my advices are helpful. > > Mònica Thank you very much for your review! Fabrizio
Attachment:
signature.asc
Description: This is a digitally signed message part