[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: monit (updated package)



Hi

Dne Sun, 16 Jan 2011 13:54:27 +0300
Sergey B Kirpichev <skirpichev@gmail.com> napsal(a):

> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/m/monit
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/m/monit/monit_5.2.3-1.dsc

Few comments:

- You don't need README.source for 3.0 source packages.
- Please rename and document debian-changes-1:5.2.3-1 patch
- Please document why is needed lintian override in
  debian/monit.lintian-overrides

There are also some Information/Pedantic lintian warnings:

P: monit: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
P: monit: no-homepage-field
I: monit: spelling-error-in-manpage usr/share/man/man1/monit.1.gz usualy usually
I: monit: spelling-error-in-manpage usr/share/man/man1/monit.1.gz overriden overridden
I: monit: possible-documentation-but-no-doc-base-registration
I: monit: spelling-error-in-binary ./usr/sbin/monit informations information
I: monit: spelling-error-in-binary ./usr/sbin/monit dependant dependent
I: monit: spelling-error-in-binary ./usr/sbin/monit dependant dependent
I: monit: spelling-error-in-binary ./usr/sbin/monit dependant dependent
I: monit: spelling-error-in-binary ./usr/sbin/monit dependant dependent

At least home page could be added and license should be fixed,
especially as the program is GPL3+. Registering documentation in
doc-base is good idea as well. 

You might consider reporting typos to upstream.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Attachment: signature.asc
Description: PGP signature


Reply to: