Hi, On 01/14/2011 05:10 PM, gregor herrmann wrote: > On Fri, 14 Jan 2011 16:29:52 +0300, Bilal Akhtar wrote: > >> The package can be found on mentors.debian.net: >> - URL: http://mentors.debian.net/debian/pool/main/l/liboauth >> - Source repository: deb-src http://mentors.debian.net/debian unstable >> main contrib non-free >> - dget >> http://mentors.debian.net/debian/pool/main/l/liboauth/liboauth_0.9.1-2.dsc > > Some notes: > - debian/rules: the override_dh_installchangelogs is not needed, > dh_installchangelogs picks up ChangeLog automatically Doesn't seem to do so in my case. > - debian/copyright: your packaging copyright at the bottom should > probably be 2010-2011. You might also want to consider to use DEP5 > format Done. > - debian/changelog: I'd rather target experimental than unstable due > to the freeze Exactly what I thought of :) done. > - debian/rules: the build log doesn't show any differences if I > comment out the LDFLAGS at the top. I guess they should be passed > to configure somehow; on the other hand it seems unnecessary, since > the build log says > "LDFLAGS: -Wall -export-symbols-regex '^oauth_.*' -Wl,--as-needed" > anyway. On the other hand dpkg-shlibdeps still warns about useless > linkage. Hm ... Corrected. > > Cheers, > gregor > Thanks for reviewing! The new package is now both on collab-maint and mentors.d.n. Bilal Akhtar. -- Bilal Akhtar - Ubuntu Developer <bilalakhtar@ubuntu.com> IRC nick: cdbs
Attachment:
signature.asc
Description: OpenPGP digital signature