On Fri, Jan 14, 2011 at 04:58:37PM +0800, Thomas Goirand wrote:
[...]
> Hi,
Hello,
>
> First of all, thanks for your interest in Webalizer. I'm a heavy user
> of it, and it's nice that you seem to want to take over the maintenance
> of this left-over. Let me give few comments...
>
Thanks for looking at it !
> >From your changelog:
>
> * New maintainer.
>
> If you are adopting the package, then you should close a bug for it
> (the package should be orphaned, then the bug should be renamed as
> "ITA" (Intention To Adopt), then you should close it in your changelog).
>
Well the maintainer has agreed (on private mail) to give it to me, and
I'm planning to ask him to sponsor it so my understanding was that we
could avoid the bureaucracy...
> I tried to do:
>
> git checkout -b upstream-sid origin/upstream-sid
>
> but it doesn't seem you are using branches. Or am I mistaking with
> names of the branches you used? Where did you store the .orig.tar.gz?
> I had to pickup the tgz from upstream, that's not good.
>
I'm using the default names for git-buildpackage: upstream and
pristine-tar.
git branch -r or looking at the gitweb page should have told you...
So I guess that maybe you're not familiar with git and would prefer
that I upload a version to mentors.d.n
> Upstream uses 2.23-03 as version name, it seems you renamed it 2.23.03.
> Why did you do that? If the "-" char is used for Debian, and it's a good
> thing to have upstream avoiding it (I would strongly recommend you to
> get it touch with Webalizer authors and let them change that), you can
> still use it for your package versionning, and produce a 2.23-03-1 in
> Debian. It's better than renaming it at least, IMHO.
Well I kept previous maintainers naming on this, even the d/watch file
is handling the rename properly so I basically didn't change anything
here ;)
>
> Then, I tried to build your package and it fails:
>
> dh_autoreconf
> /usr/share/aclocal/dotconf.m4:5: warning: underquoted definition of
> AM_PATH_DOTCONF
> /usr/share/aclocal/dotconf.m4:5: run info '(automake)Extending aclocal'
> /usr/share/aclocal/dotconf.m4:5: or see
> http://sources.redhat.com/automake/automake.html#Extending-aclocal
> configure.in:37: warning: AC_TRY_RUN called without default to allow
> cross compiling
> autoconf: Undefined macros:
> configure.in:322:AC_MSG_NOTICE(Done. Type 'make' to continue with build.)
> configure.in:36:AC_SYS_LARGEFILE
> configure.in:39:AC_CHECK_DECL(altzone,OPTS="-DHAVE_ALTZONE
> ${OPTS}",,[#include <time.h>])
> configure.in:37: warning: AC_TRY_RUN called without default to allow
> cross compiling
> autoconf: Undefined macros:
> configure.in:327:AC_MSG_NOTICE(Done. Type 'make' to continue with build.)
> configure.in:36:AC_SYS_LARGEFILE
> configure.in:39:AC_CHECK_DECL(altzone,OPTS="-DHAVE_ALTZONE
> ${OPTS}",,[#include <time.h>])
> configure.in:37: warning: AC_TRY_RUN called without default to allow
> cross compiling
> autoconf: Undefined macros:
> configure.in:300:AC_MSG_NOTICE(Done. Type 'make' to continue with build.)
> configure.in:36:AC_SYS_LARGEFILE
> configure.in:39:AC_CHECK_DECL(altzone,OPTS="-DHAVE_ALTZONE
> ${OPTS}",,[#include <time.h>])
> dh_autoreconf: autoreconf -f -i returned exit code 1
> make: *** [build] Error 9
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
>
Strange, I've never seen such errors it has always build fine on sid
either directly or via pbuilder, I'll double check.
Also I don't have any /usr/share/aclocal/dotconf.m4 file on my system,
can you check from which package it comes from so that I can test with
it too ?
> IMHO, the old format 1.0 was fine, and unless you really know what
> you are doing, and do it well, keep it. :)
Well the package had a lot of patches using dpatch so moving to quilt
was a natural thing to do, now I've learned a lot on using quilt, I will
not revert back ;)
>
> Let me know when you have fixed the above issue, and I'll look further.
I can't reproduce the issue now, so I hope you can either fix it on your
side or help me to reproduce it.
Thanks again for your interest in webalizer.
Best Regards,
--
Julien Viard de Galbert <julien@vdg.blogsite.org>
http://silicone.homelinux.org/ <julien@silicone.homelinux.org>
GPG Key ID: D00E52B6 Published on: hkp://keys.gnupg.net
Key Fingerprint: E312 A31D BEC3 74CC C49E 6D69 8B30 6538 D00E 52B6
Attachment:
signature.asc
Description: Digital signature