[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: liboauth (updated package)



On Fri, 14 Jan 2011 16:29:52 +0300, Bilal Akhtar wrote:

> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/l/liboauth
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/l/liboauth/liboauth_0.9.1-2.dsc

Some notes:
- debian/rules: the override_dh_installchangelogs is not needed,
  dh_installchangelogs picks up ChangeLog automatically
- debian/copyright: your packaging copyright at the bottom should
  probably be 2010-2011. You might also want to consider to use DEP5
  format
- debian/changelog: I'd rather target experimental than unstable due
  to the freeze
- debian/rules: the build log doesn't show any differences if I
  comment out the LDFLAGS at the top. I guess they should be passed
  to configure somehow; on the other hand it seems unnecessary, since
  the build log says
  "LDFLAGS:                -Wall -export-symbols-regex '^oauth_.*' -Wl,--as-needed"
  anyway. On the other hand dpkg-shlibdeps still warns about useless
  linkage. Hm ...

Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: Kurt Ostbahn & Die Kombo: Wea is ea und wos is ea zu dia

Attachment: signature.asc
Description: Digital signature


Reply to: