[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libzeep

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-01-11 08:26, Maarten L. Hekkelman wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "libzeep".
> 
> * Package name    : libzeep
>   Version         : 2.0.1-1
>   Upstream Author : Maarten L. Hekkelman
> * URL             : http://www.cmbi.ru.nl/libzeep/
> * License         : Boost
>   Section         : libs
> 
> It builds these binary packages:
> libzeep-dev - XML Library for SOAP servers written in C++ (development
> files)
> libzeep2   - XML Library for SOAP servers written in C++
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 609541
> 
> My motivation for maintaining this package is:
> I'm the upstream author. This software is used in several of the
> projects I'm involved in and has been in production for well over a year
> now. The inclusion of libzeep will enable me to submit more software,
> like e.g. mrs <http://mrs.cmbi.ru.nl/>.
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/l/libzeep
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/l/libzeep/libzeep_2.0.1-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
> 
> -maarten hekkelman
> 
> 

Hey

I tried to build your package, but it fails in a clean chroot.  Most
likely you are missing a Build-Depends or two.  Based on the output I am
guessing they are related to libboost.

cc -MD -c -o obj/doctype.o src/doctype.cpp  -iquote ./ -g -fPIC -O3
- -pthread -shared
src/doctype.cpp:10:31: error: boost/tr1/tuple.hpp: No such file or directory
src/doctype.cpp:11:38: error: boost/algorithm/string.hpp: No such file
or directory
src/doctype.cpp:12:29: error: boost/foreach.hpp: No such file or directory
src/doctype.cpp:14:26: error: boost/bind.hpp: No such file or directory
src/doctype.cpp:15:45: error: boost/enable_shared_from_this.hpp: No such
file or directory
In file included from src/doctype.cpp:18:
./zeep/xml/doctype.hpp:13:46: error: boost/ptr_container/ptr_vector.hpp:
No such file or directory
./zeep/xml/doctype.hpp:14:44: error: boost/ptr_container/ptr_list.hpp:
No such file or directory
./zeep/xml/doctype.hpp:15:33: error: boost/tuple/tuple.hpp: No such file
or directory
./zeep/xml/doctype.hpp:16:43: error: boost/filesystem/operations.hpp: No
such file or directory


Also d/copyright needs to contain the entirely licenses.  The only
licenses you can refer to without including a full copy of them are
those listed in /usr/share/common-licenses (with the exception of the
BSD license, which we are trying to remove from common-licenses).  On a
related note, the LICENSE_1_0.txt should not be installed.

In d/rules you could shorten it a bit.  configure/configure-stamp is
definitely not doing anything useful that is not handled by build-stamp
itself.  I believe you could reduce your d/rules file to:

- ---- START
#!/usr/bin/make -f
%:
	dh $@

override_dh_auto_install:
	$(MAKE) LIBDIR=$(CURDIR)/debian/libzeep2/usr/[...]
        $(MAKE) LIBDIR=$(CURDIR)/debian/libzeep-dev/[...]

.PHONY: ...
- ---- END

If you used debhelper (>= 7.0.50~).  You are not required to do this, I
am just mentioning it. :)

~Niels

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNMCktAAoJEAVLu599gGRC7AAQALRIWDVx+lpcQtm9f+7MlsLx
aZfSQIMBMhmzwQ59SAOaiDME/+of6eWT3MYASF8WjvzWMRCtfS81nHQwpOgieIw1
o07SZ5HDT4AlOm2WagWVGse7vpE8SPH18SKVaw4WEN0iFBZuHI2qB0/7dgyByvbg
HC6E7K8ELBbtqNjBxD9+SwNd9AxtQaI0iOqM3vlXO2OUpOlDIFHKWKoHd28hPGnZ
uzPrQlvPxMrD6+X+fN4w4P6/Jd88IJ7/GyPe8BOppK5/QjMyJT2cJe1R0L2TlKTj
bQKn8PhGvah0LbpuVZweadWzhIfKAF0ePGv9ZZtQGU6e95Whc7+SX9jtwa68Mbqh
7vDjUjMf3d8hN2pD97SlqKC/e9Ll9S5dcylWvuWuGUAewr7bQ2jKdDmVJ+sCGduT
7zlHMxiXhNYT0x7orYkPDHtQtKs7Mls7OMje3WAuqme5GqM2X81NQm3nVXw1TcUN
DfQ7vt3z5ebBrJbXyVH2tWUtAfd+4i5sLdUFY50F5cz7cGuiPyU3oyBzw7eOzb0C
Fi1IfMTw29VUzoRanRfYEECQSdYsAc7MZXK0RvYAv44GZQJMrBAD4m77090UMIL6
E7cS8IbObVejJ19GjZ+w1LQ6YeDJGRCEA0CM6JT2iiEqJ4r45evXM7im+Wa1WOu9
PCXntk9kIHoo5mYzLXI2
=B9w8
-----END PGP SIGNATURE-----
Reply to: