Le lundi 13 décembre 2010 à 18:18 -0500, Paul Tagliamonte a écrit : > 2010/12/13 Guillaume Delacour <gui@iroqwa.org>: > > dget http://mentors.debian.net/debian/pool/main/s/sslh/sslh_1.7a-3.dsc > > > > Howdy, > > I'm not a DD, and I can't upload, but here are some notes ( mostly nit-picks ) And this is also a good way to help me. > > Might want to consider using DEP5 and DEP3 Yes, i have to consider these and changes my packages. Sslh should be migrated in the next upstream release. > > You should consider breaking up the Depends in the control to newline > after 80 chars It's right too. I've modified that for future release of the package. > > One lintian issue on the deb: > > P: sslh: no-upstream-changelog > > I'm not sure if this is just because I compiled it on Ubuntu, or if > it's actually an issue. I'll dig into it later if no one responds > telling me I'm wrong ( a bit short on time right now ) $ lintian -IE --pedantic sslh_1.7a-3.dsc sslh_1.7a-3_amd64.changes $ echo $? $ Reports no problem or pedantic. http://packages.debian.org/sid/i386/sslh/filelist confirm that the upstream changelog is included in the -3 (and all previous releases). > > I get why you do it, but this is interesting in init :) > > # Do NOT "set -e" > > You can use a patch to put the file where it should be ( and not keep > it in the debdir ). I don't really understand this remark, debian/init is installed by dh_installinit, whis is why i just put the initscript in debian/. > > There is a lot of odd stuff going on, but it looks OK at first glance. > Like I said, I'll look more at it later unless someone else gets there > first :) Thanks, please note that the package have been uploaded a few hours ago by wjl, so changes and remarks will be included in next release of the packagE. > > Cheers! > Paul > > > -- > All programmers are playwrights, and all computers are lousy actors. > > #define sizeof(x) rand() > :wq > >
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=