[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: tartarus

Hi Stefan,

22/11/2010 11:52 +0100, Stefan Tomanek wrote:
> Dear mentors,
> I am looking for a sponsor for my package "tartarus".
> * Package name    : tartarus
>   Version         : 0.9.4-2
>   Upstream Author : Stefan Tomanek <stefan.tomanek+tartarus@wertarbyte.de>
> * URL             : http://wertarbyte.de/tartarus.shtml
> * License         : GPLv3
>   Section         : utils
> It builds these binary packages:
> tartarus   - script based backup system
> The package appears to be lintian clean.
> The upload would fix these bugs: 604447
> My motivation for maintaining this package is:
> I've written tartarus as a simple backup solution for my dedicated server.  It
> uses parts of the unix toolshed that should be available even in the most basic
> rescue system, making recovery easy in case things go wrong. By using Bash and
> Perl, the program is easily extendable and offers various hooks that can be
> used to modify its behaviour, while including features like LVM snapshots,
> on-the-fly-uploading and compression/encryption out of the box. I created the
> package to simplify the installation on now roughly > 1100 systems using this
> program (http://wertarbyte.de/stats/tartarus-use.png) on a regular basis and I
> would really like to this this included into Debian.
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/t/tartarus
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/t/tartarus/tartarus_0.9.4-2.dsc
> I would be glad if someone uploaded this package for me.

I'm not a DD, but here's my (quick) review for your package. I hope it's useful for you:

* Lintian checking (it's not Lintian clean):
   - I: tartarus source: debian-watch-file-is-missing
     It's a good practice to add a watch file.
   - W: tartarus source: out-of-date-standards-version 3.8.0 (current is 3.9.1)
     You should check [1] and upgrade to Standards-Version to 3.9.1
   - I: tartarus: spelling-error-in-manpage usr/share/man/man1/tartarus.1.gz managable manageable
     You can find this spelling error in 
         $ grep -nR managable *
         bin/tartarus:26:# configuration from easily managable configuration files. It can store
     If you are the upstreamer, you can easily correct it in upstream source before packaging.
   - P: tartarus: no-upstream-changelog
     It could be nice if upstream have an upstream changelog and it could be accessible 
     from Debian package.

* Debian files checking:
   - debian/changelog: I think you should not add previous changes before entering the package to Debian. 
     So this package version should be 0.9.4-1, altough you had it before in a personal repo. 
   - debian/rules: You can delete commented lines that tell us you are using a template.
   - debian/menu: Consider to create it.
   - debian/patches: You have a debian/patches automatic file (debian-changes-0.9.4-2): If this patch is necessary 
     for Debian package, you should comment why in the patch file. If it's fine to have this change in upstream 
     and you're the upstreamer, you can change it in upstream code before packaging. 

* Ustream source checking:
   - Upstream source should be licensed.

I haven't checked how program works.

If any other person from the list sees a mistake in my review, "reviews of my review" are welcomed!


[1] http://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: