[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: wicd-client-kde

On Wed, 3 Nov 2010 15:03:17 +0100, Iker Salmón San Millán wrote:

> El 3 de noviembre de 2010 13:05, Iker Salmón San Millán <shaola@esdebian.org
> > escribió:
> > I am still wainting upstream response about changing the name to wicd-qt,
> > but till then i would be glad if someone makes a new review of the package.
> Here is the response:
> >Well technically this is a KDE App, which heavily depends on the KDE libs,
> not only on Qt, and is designed to integrate in the KDE >desktop. If you
> call it wicd-qt, it might be misleading if someone doesn't want any kdelibs
> dependencies for whatever reason. So I do >not recommend using wicd-qt for
> the package name, but instead wicd-kde, like your potential mentor said, for
> consistency.

wicd-kde is fine then.

> >About the binary name, I don't plan to change it to wicd-kde, because it
> doesn't contains/substitute the wicd daemon, I think it's >important that
> the users understand it's just a client for the daemon.
> >So the package wicd-gtk depends on gtk (and not GNOME) and provides the
> wicd-client binary.

The wicd-client binary is just a wrapper, that runs wicd-curses or wicd-gtk,
depending on whether X is available or not.

wicd-gtk is really a separate client, /usr/bin/wicd-gtk .
Also /usr/bin/wicd-curses is a client, and /usr/bin/wicd-cli is another.
I see /usr/bin/wicd-client-kde failing being consistent here :-)

Anthony, would it be possible for you to reconsider this decision, and call
it /usr/bin/wicd-kde?

> That makes sense to me.  I don't know what to do now.  I have to correct the
> description of the package just to make clear that not only depends on qt it
> also depends on kdelibs

Yes, please, correct the package description.

Other than this, the package seemed fine to me earlier today. I'll have a more
careful check as soon as the binary name issue is solved.


 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature

Reply to: