Re: RFS: 9menu (updated package)

[Ansgar Burchardt <ansgar@43-1.org>]

Hi,

Daniel Echeverry <epsilon77@gmail.com> writes:
>> I did take a look at your package.  Some comments:
>>
>>   · debian/changelog: There is a space missing in the last line.
> I am a bit confused, I don't understand this

You wrote

  +Change all patches from quilt

instead of

  + Change all patches from quilt

in the changelog.  I corrected this and another typo in the changelog
(see the diff below).

> I reuploaded my package to mentors, please check out:
> http://mentors.debian.net/debian/pool/main/9/9menu/9menu_1.8-3.dsc

Uploaded.  Thanks for your work.

Three things you might want to correct in the next upload:

 · debian/rules: The override_dh_auto_clean target is not necessary as
   it just calls dh_auto_clean with no options.
 · debian/rules: You should remove the generated upstream changelog in
   the clean target.  For example by calling "dh_clean changelog".
 · There is a warning from dpkg-shlibdeps:
     dpkg-shlibdeps: warning: dependency on libXext.so.6 could be
     avoided if "debian/9menu/usr/bin/9menu" were not uselessly linked
     against it (they use none of its symbols).
   You should try not linking against the library and check if 9menu
   still works correctly.

Regards,
Ansgar

commit 9d73b3331c3cdd8ed294760b0b7be53329c87389
Author: Ansgar Burchardt <ansgar@43-1.org>
Date:   Mon Nov 1 09:52:02 2010 +0100

    Correct two typos in d/changelog

diff --git a/debian/changelog b/debian/changelog
index 8b0c038..04cc61c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,9 +7,9 @@
     + Bumped standard versions 3.9.1
     + Remove dpatch from Build-Depends
     + Set myself as Maintainer
-    + Changed debhelper to 7.50 in B-D
+    + Changed debhelper to 7.0.50 in B-D
   * debian/patches
-    +Change all patches from dpatch to quilt
+    + Change all patches from dpatch to quilt
   * debian/install
     + Removed
   * debian/compat