Hello Leonid,
On Wed, 9 Jun 2010 18:36:27 +0200, David Paleino wrote:
> On Wed, 09 Jun 2010 19:04:44 +0300, Leonid Borisenko wrote:
>
> > * Package name : uwsgi
> > Version : 0.9.5.1-1
> > Upstream Author : Roberto De Ioris <roberto@unbit.it>
> > * URL : http://projects.unbit.it/uwsgi/wiki
> > * License : GPL-2+
> > Section : web
>
> I'm going to review it ASAP.
While I'm interested in the package, I can't really sponsor it -- I have almost
no knowledge of CDBS to help you there.
However, here are a couple of things you should fix :)
- in debian/rules you're using some bashisms, like using *.{o,pyc}. You should
avoid this, by expanding those yourselves, i.e. "*.o *.pyc".
- you should remove debian/DEBIAN/ from the package
- in debian/control, instead of build-depending on python{2.5,2.6} and
python{2.5,2.6}-dev, you should use python-all-dev. You should keep
python3.1-dev though, since it's not in the -all- package yet.
- debian/control: the package "uwsgi-various" should be better named IMHO,
maybe uwsgi-extra? This is to stay consistent with other packages in Debian
- debian/control: some packages have the same long description. Please fix
this. (uwsgi-plugin-lua, uwsgi-plugin-psgi)
- debian/control , package "uwsgi". Why are you hardcoding the dependency to
uwsgi-python2.5 ? I suggest you use:
uwsgi-python2.5 | uwsgi-python2.6 | uwsgi-python3.1
, drop the "Provides: uwsgi-any" from other uwsgi-python* packages, and fix
the dependency of plugins from "uwsgi | uwsgi-any" to "uwsgi". It should work
the way you intended it :)
- debian/control: libapache2-mod-uwsgi, does it work only with
apache2-mpm-worker, apache2-mpm-prefork and apache2-mpm-itk? Doesn't it work
with other MPMs?
You might want to give one default, and add an alternative to apache2-mpm.
Example:
apache2-mpm-worker | apache2-mpm
So you get all other MPMs for free, and you still get the default one you
chose (if no other is installed) :)
I hope I didn't miss anything :)
Have a nice day,
David
--
. ''`. Debian developer | http://wiki.debian.org/DavidPaleino
: :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
`. `'` GPG: 1392B174 ----|---- http://deb.li/dapal
`- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
Attachment:
signature.asc
Description: PGP signature