Re: RFS: vera++

[Joachim Reichel <joachim.reichel@gmx.de>]

Hi Mathieu,

>> Unfortunately, you changed the original tarball locally (size 52320)
>> compared to revision -1 (size 53263), but did not upload it (because the
>> Debian revision is -2, and you did not pass -sa to dpkg-buildpackage).
>> And mentors.d.o still has the old tarball.
>>
>> $ dpkg-source -x vera++_1.1.1-2.dsc
>> dpkg-source: error: File ./vera++_1.1.1.orig.tar.gz has size 53263
>> instead of expected 52320
>>
>> Before simply using -sa please check why the original tarball changed.
> 
> I used dget to get the original src and reuploaded version -2. I have
> absolutely no idea what could have happen.
> 
> I believe this should works now:
> 
> $ dget http://mentors.debian.net/debian/pool/main/v/vera++/vera++_1.1.1-2.dsc
> $ dpkg-source -x vera++_1.1.1-2.dsc
> dpkg-source: extracting vera++ in vera++-1.1.1
> dpkg-source: info: unpacking vera++_1.1.1.orig.tar.gz
> dpkg-source: info: applying vera++_1.1.1-2.diff.gz

yes, works. Sorry for the delay, I missed your last mail.

- While you fixed the lintian warnings I mentioned in the first review,
there are new warnings that should get fixed:

I: vera++ source: debian-watch-file-is-missing
W: vera++ source: out-of-date-standards-version 3.8.2 (current is 3.8.3)
I: vera++: possible-documentation-but-no-doc-base-registration

- It is very inconvenient to use the program, even with the default
rules. The examples given in the man page do not work in the form they
are given there: You have to set VERA_ROOT or copy the rules to
~/.vera++ or the current directory. It would be nice if the program
would as last possibility check a predefined location where the default
rules get installed (see also (*) below). You should talk with upstream
about this. Maybe you can patch the program to do that.
(This is not a blocker for an upload, but improving the manpage
accordingly is).

These issues are still open:

- debian/copyright: You should mention the GPL version for the Debian
packaging (and adjust the link if necesary).

- manpage: Please fix the layout of the OPTIONS section (have a look at
other manpages). Please change the synopsis section to describe the
basic invocation syntax (see other manpages). The man page should
mention the location of the example scripts (maybe in the examples
section, a demonstration how to set VERA_ROOT to use the provided rules).

Best regards,
  Joachim