[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sqlkit



Hi Laslo,

  thanks for your time.

On Fri, Sep 04, 2009 at 05:54:17PM +0200, Laszlo Boszormenyi wrote:
> Hi Alessandro,
> 
> On Fri, 2009-09-04 at 14:05 +0200, Alessandro Dentella wrote:
> > I am looking for a sponsor for my package "sqlkit".
> [...]
> > It builds these binary packages:
> > python-sqlkit - GUI library to edit data of databases
> > 
> > The package appears to be lintian clean.
>  Sure, but it fails to build here. It has other problems as well.
> Relevant lines:
> patches: debian/patches/00_setup.diff debian/patches/01_locale.diff debian/patches/03_manifest.diff
> Trying patch debian/patches/00_setup.diff at level 1 ... 0 ... success.
> Trying patch debian/patches/01_locale.diff at level 1 ... 0 ... success.
> Trying patch debian/patches/03_manifest.diff at level 1 ... 0 ... success.
> if [ "debian/stamp-patched" != "reverse-patches" ]; then touch debian/stamp-patched; fi
> if [ "debian/stamp-patched" != "reverse-patches" ] ; then \
> 		/usr/bin/make -f debian/rules update-config ; \
> 	fi
> pyversions: missing XS-Python-Version in control file, fall back to debian/pyversions
> make[1]: Entering directory `/root/compile/sqlkit-0.8.6'
> make[1]: Nothing to be done for `update-config'.
> make[1]: Leaving directory `/root/compile/sqlkit-0.8.6'
> cd . && python setup.py build --build-base="/root/compile/sqlkit-0.8.6/./build"
> You need to install setuptools to use this setup.py script
> make: *** [debian/python-module-stampdir/python-sqlkit] Error 1
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
> 
> In short, please make your patches level 1 

fixed

> and add XS-Python-Version

When I added that I had complaints from CDBS that suggested to use
pyversion...:

/usr/share/cdbs/1/class/python-distutils.mk:67: WARNING:  Use of XS-Python-Version and XB-Python-Version fields in debian/control is deprecated with pysupport method; use debian/pyversions if you need to specify specific versions.

So, what am I supposed to do?


> field to control. I know that they are optional but if you have time
> please.
> You miss python-setuptools as build dependency. Also is it really

ops, fixed

> necessary to depend on all SQL related Python support packages? Some may
> need it for PostgreSQL only and pulling in MySQL related packages is a
> bit of overkill. Consider an 'or' dependency of PostgreSQL and MySQL.

I put only the 2 very popular ones, sqledit supports many more.

At the beginning I just put postgres and mysql driver in 'Suggest' but
I think that in front of a very limited disk saving we could just create a
probelm to not expert users that could miss the explanation of what is
missing: both of them are less than 0.5 MB once installed.

So I'd really prefer to leave those 2 drivers as dependencies.


Rebuilding the package should I leave the debian version with -1 or should I
increment it?

thanks again

sandro
*:-)

-- 
Sandro Dentella  *:-)
http://sqlkit.argolinux.org        SQLkit home page - PyGTK/python/sqlalchemy


Reply to: