Re: RFS: sqlkit

[Laszlo Boszormenyi <gcs@debian.hu>]

Hi Alessandro,

On Fri, 2009-09-04 at 14:05 +0200, Alessandro Dentella wrote:
> I am looking for a sponsor for my package "sqlkit".
[...]
> It builds these binary packages:
> python-sqlkit - GUI library to edit data of databases
> 
> The package appears to be lintian clean.
 Sure, but it fails to build here. It has other problems as well.
Relevant lines:
patches: debian/patches/00_setup.diff debian/patches/01_locale.diff debian/patches/03_manifest.diff
Trying patch debian/patches/00_setup.diff at level 1 ... 0 ... success.
Trying patch debian/patches/01_locale.diff at level 1 ... 0 ... success.
Trying patch debian/patches/03_manifest.diff at level 1 ... 0 ... success.
if [ "debian/stamp-patched" != "reverse-patches" ]; then touch debian/stamp-patched; fi
if [ "debian/stamp-patched" != "reverse-patches" ] ; then \
		/usr/bin/make -f debian/rules update-config ; \
	fi
pyversions: missing XS-Python-Version in control file, fall back to debian/pyversions
make[1]: Entering directory `/root/compile/sqlkit-0.8.6'
make[1]: Nothing to be done for `update-config'.
make[1]: Leaving directory `/root/compile/sqlkit-0.8.6'
cd . && python setup.py build --build-base="/root/compile/sqlkit-0.8.6/./build"
You need to install setuptools to use this setup.py script
make: *** [debian/python-module-stampdir/python-sqlkit] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2

In short, please make your patches level 1 and add XS-Python-Version
field to control. I know that they are optional but if you have time
please.
You miss python-setuptools as build dependency. Also is it really
necessary to depend on all SQL related Python support packages? Some may
need it for PostgreSQL only and pulling in MySQL related packages is a
bit of overkill. Consider an 'or' dependency of PostgreSQL and MySQL.

Regards,
Laszlo/GCS