Hello Charles,
Charles Plessy <plessy@debian.org> wrote:
> Here are a couple of minor comments on the package, that can be adressed in a
> later upload.
> - How about maintaining the source package in a VCS?
I thought this is the work of upstream, isn't it?
> - Why is the cron script in /etc/cron.daily prefixed by ‘zz-’?
I have written into the README.Debian file: because backup could take
a longer time, so it should be the last cron job.
> - The dual changelog / ChangeLog is quite confusing because they are both
> Debian changelogs.
That is right. But the upstream developer (= old maintainer) have
written many details about developement steps, which don't need to be
inside the Debian changelog.
> - ${shlibs:Depends} is not needed in debian/control.
Thanks!
> - In README.Debian, “alle directories” should be “all directories”.
Done.
> - You chose GPL version 3 for the packaging, but backup2l is GPL version 2 or
> superior. If you appreciate the possibility of upgrading from version 2 to
> 3, how about adding an ‘or (at your option) any later version’ clause?
Is it o.k. to define the next version of GPL inside the debian package,
that means: in debian/copyright (for source and package) and manpage?
The upstream developer set it to GPL-2.
> - Lastly, lintian found some bugs in the manpages. Since you are in contact
> with Gundolf, this is a good opportunity to get then fixed upstream directly.
These lintian messages seems to be from the old version 1.4, isn't it?
Fondest regards,
Joachim Wiedorn
Attachment:
signature.asc
Description: PGP signature