Hi!, * Christoph Egger (debian@christoph-egger.org) wrote: > On Sat, Dec 12, 2009 at 11:28:19AM -0500, Marcos Talau wrote: [...] > > Hi! > > /--- debian/rules > | build: patch build-stamp > \--- > > For me that looks like you can't depend on patch having finished > when build-stamp runs. So theoretically on a parallel build the whole > build target could have ben run before your sources are patched. I > doubt you want that. That's the only blocker I have found so far for > this package. > > Minor point, you have $(TMP_DIR) = $(CURDIR)/debian/ziproxy but in > install you use > > /--- > | $(MAKE) DESTDIR=$(CURDIR)/debian/ziproxy install > \--- > Fixed! > If you decide to switch to the new 3.0 source format you can use > the bzip2 tarball from upstream unmodified (and get some extra > benefits like automagic quilt handling) -- just a random thought > wouldn't prevent me from sponsoring. > > Commenting the quilt patches (as suggested by lintian!) would be > really nice, I found myself trying to figure out what some patch was > supposed to do way too often. (The other Info level stuff might be > interesting for you was well). > > Regards > > Christoph > > -- > /"\ ASCII Ribbon : GPG-Key ID: 0xD49AE731 > \ / Campaign : CaCert Assurer > X against HTML : Debian Maintainer > / \ in eMails : http://www.debian.org/ > > http://www.christoph-egger.org/ I switch the package to DebSrc3.0 and added DEP-3 compliant headers in patches. Regards, Talau
Attachment:
signature.asc
Description: Digital signature