Re: RFS: bluemindo (updated package)
Uploaded, thanks for your contribution to Debian!
For future uploads, please contact this list and I'll sponsor you if I am able.
Apologies for the other mail, pressed the wrong button.
Some comments for the next upload:
audioscrobbler.py is available in seven packages in Debian. It would
be nice if you could ask sonata upstream to split it out into a
separate source package (and upload to pypi.python.org) that could be
shared by all the other users of these classes. You might like to then
file a bug on each of the upstreams asking them to switch to it and
package that for Debian.
The upstream Makefile declares prefix=/usr, this is extremely wrong.
/usr is reserved for the package system, stuff installed from source
should have prefix=/usr/local by default.
The upstream INSTALL file added python-eggtrayicon as an optional
dependency, you should probably add that to the Suggests in
debian/control.
The glade format and libraries are deprecated in favour of GtkBuilder
and GTK+, please ask upstream to consider switching to them. IIRC
saving to GtkBuilder format was added in glade 3.5.
You might want to look at this Ubuntu bug and forward it upstream or
recommend it be closed:
https://bugs.launchpad.net/ubuntu/+source/bluemindo/+bug/261817
You might want to have a look at the output of 'whohas bluemindo' and
see if there is anything in other distros that could be useful in
Debian or upstream. This includes bugs, patches etc.
The PTS page says this: There were override disparities found in suite
unstable: * bluemindo: Override says sound - optional, .deb says sound
- extra. I suggest filing a bug on ftp.debian.org to get the
ftpmasters to drop their override:
http://lists.debian.org/debian-devel-announce/2009/08/msg00001.html
You can use the debcheck output as justification for removing this override:
http://qa.debian.org/debcheck.php?dist=unstable&package=bluemindo
You are using a different email address in this RFS than in the
Maintainer field of the package, is that intended?
Please add the URLs where the patches are forwarded to the patch headers.
Please run this: sed -i -e 's/listen from/listen to/' debian/control
In future, the debian/changelog file could be slightly more verbose,
for example:
bluemindo (0.3-1) unstable; urgency=low
* New upstream release
- includes all patches, drop them from debian/patches
- includes manual page, drop debian/bluemindo.1
* Bumped Standards-Version to 3.8.3, no changes needed
* Added a patch to correct seekbar's adjustment, so it covers the whole song
* Added a patch to correct crashes in the random playlists
* Added a patch to avoid freezes and crashes in the album view
* Added a patch to correct random playlists' behaviour
-- Thibaut GIRKA <thibaut.girka@gmail.com> Thu, 27 Aug 2009 11:03:45 +0200
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: