[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: opendchub (updated package)

On Tue, 2009-08-25 at 18:43 +0200, Patrick Matthäi wrote:
> Sorry, you made a step in the wrong way:
> * Remove debian/patches, now merged in git
>  Makefile              |  588
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/commands.c        |    2
>  src/perl_utils.c      |    9
>  19 files changed, 1196 insertions(+), 2 deletions(-)

Good call, that Makefile shouldn't be there, its not in the new upstream
sources but seems to have snuck in the last NMU.  I have uploaded
0.8.0-2 fixing this:


> You should *never* do modifications directly in the source, the
> debian/patches behaviour was correct.

I never did modifications on the upstream source directly; I had git
branches[0] set up with their own copies of the source, so modifications
are self-contained within those branches.

> Please revert it.

Please see this[1] for my rationale behind the debian/patches move.

[0]  See the gitweb at http://code.zakame.net/opendchub.git
[1]  Message-Id: <1251211701.3814.57.camel@perlis.zakame.net>

Zak B. Elep -- 1486 7957 454D E529 E4F1  F75E 5787 B1FD FA53 851D
  I like the idea of 256 bits, though: 32 for the (Unicode) character
leaves room for 224 Bucky bits, which ought to be enough for anyone.
                        -- Roland Hutchinson, in alt.folklore.computers

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: