Re: RFS: opendchub (updated package)
-----BEGIN PGP SIGNED MESSAGE-----
Zak B. Elep schrieb:
> On Tue, 2009-08-25 at 18:43 +0200, Patrick Matthäi wrote:
>> Sorry, you made a step in the wrong way:
>> * Remove debian/patches, now merged in git
>> Makefile | 588
>> src/commands.c | 2
>> src/perl_utils.c | 9
>> 19 files changed, 1196 insertions(+), 2 deletions(-)
> Good call, that Makefile shouldn't be there, its not in the new upstream
> sources but seems to have snuck in the last NMU. I have uploaded
> 0.8.0-2 fixing this:
src/commands.c | 2
src/perl_utils.c | 9 ++-
There are still those files left.
I will not sponsor packages who have direct changes in sources.
>> You should *never* do modifications directly in the source, the
>> debian/patches behaviour was correct.
> I never did modifications on the upstream source directly; I had git
> branches set up with their own copies of the source, so modifications
> are self-contained within those branches.
>> Please revert it.
> Please see this for my rationale behind the debian/patches move.
>  See the gitweb at http://code.zakame.net/opendchub.git
>  Message-Id: <firstname.lastname@example.org>
Mit freundlichem Gruß / With kind regards,
GNU/Linux Debian Developer
Always if we think we are right,
we were maybe wrong.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
-----END PGP SIGNATURE-----