[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: cconv -- A iconv based simplified-traditional chinese conversion tool



Hi

Dne Tue, 12 May 2009 16:21:32 +0800
Vern Sun <s5unty@gmail.com> napsal(a):

> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/c/cconv
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/c/cconv/cconv_0.5.2-1.dsc

- you might want to use debhelper 7 features (dh) to simplify
  debian/rules, your package seems to be good candidate to this
- lintian slightly complains:
P: cconv-dev: copyright-refers-to-symlink-license usr/share/common-licenses/GPL 
P: cconv: copyright-refers-to-symlink-license usr/share/common-licenses/GPL 
I: cconv: extended-description-is-probably-too-short
- any reason why library is placed in /usr/lib/cconv?
- you should split the library to libcconv0 and rename devel package to
  libcconv-dev
- please write useful description, pointing user to url is not a useful
  description
- you need to list all copyrights and licenses in debian/copyright
- Vcs-* fields are for debian packaging not for upstream
- -dev package is not a metapackage
- cconv man page is obviously generated, you should include it's
  sources and generate it during build
- README.Debian is useless
- why do you install empty file NEWS?

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Attachment: signature.asc
Description: PGP signature


Reply to: