Re: RFS: udav

[Paul Wise <pabs@debian.org>]

On Mon, May 4, 2009 at 3:20 AM, Salvatore Bonaccorso
<salvatore.bonaccorso@gmail.com> wrote:

> I uploaded a new fixed version to mentors.debian.net
> dget http://mentors.debian.net/debian/pool/main/u/udav/udav_0.5.1-1.dsc

Some more things:

Some of the images in help/pics/ contain this comment but there
doesn't seem to be any source code for them nor any indication of how
they were generated (other than using ghostscript).

Image generated by GPL Ghostscript (device=pnmraw)

While upstream's udav.png doesn't contain this comment, it does use
transparency and what looks like a 3D effect, is there any source code
for that?

The file*.xpm and other icons look suspiciously like the icons from
Windows 3.1 (or Win95, not sure).

The icons stuff needs fixing, I suggest the following:

udav.desktop Icon=udav
udav.menu icon16x16=/usr/share/icons/hicolor/16x16/apps/udav.xpm
udav.menu icon32x32=/usr/share/icons/hicolor/32x32/apps/udav.xpm
install src/udav.png /usr/share/icons/hicolor/64x64/apps/udav.png
install src/xpm/udav.xpm /usr/share/icons/hicolor/16x16/apps/udav.xpm
convert -scale 32x32 src/udav.png /usr/share/icons/hicolor/32x32/apps/udav.png
convert -scale 32x32 src/udav.png /usr/share/icons/hicolor/32x32/apps/udav.xpm

desktop-file-validate complains:

$ desktop-file-validate debian/*.desktop
debian/udav.desktop: warning: value
"Application;Education;Science;Math;" for key "Categories" in group
"Desktop Entry" contains a deprecated value "Application"

The blank lines in the desktop file aren't needed.

Be sure to send the .desktop file upstream.

There are some gcc warnings:

qmglcanvas.cpp:187: warning: unused parameter 'mes'
mgl_addon.cpp:53: warning: unused parameter 'lib'
mgl_addon.cpp:53: warning: unused parameter 'func'

And a dpkg-shlibs warning:

dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be
avoided if "debian/udav/usr/bin/udav" were not uselessly linked
against it (they use none of its symbols).

DH_VERBOSE is usually off and only turned on for debugging.

Sourceforge bug URLs can be reduced to this:

http://sf.net/support/tracker.php?aid=1234

-- 
bye,
pabs

http://wiki.debian.org/PaulWise