[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: udav

Hi Paul and all

On Sun, May 03, 2009 at 11:45:21AM +0800, Paul Wise wrote:
> On Sun, May 3, 2009 at 6:39 AM, Salvatore Bonaccorso
> <salvatore.bonaccorso@gmail.com> wrote:
> > - dget http://mentors.debian.net/debian/pool/main/u/udav/udav_0.5.1-1.dsc
> Some feedback based on the diff.gz:
> Please get your package description reviewed by the
> debian-l10n-englist email list, it contains some gramatical errors.

I got a review, and adapted the control file. Is now more correctly?

> It might be a good idea to put an icon in the menu file. From the
> upstream screenshots it looks like they have one you could use.
> Please add a FreeDesktop menu file too, otherwise udav will not be
> visible from the GNOME/LXDE menus.

As you suggested I have now an icon file into the Debian menu, and
also added a udav.desktop file for the GNOM/LXDE menu entries.

> ChangeLog.txt should be a parameter to dh_installchangelogs instead of
> in debian/docs.

Yes this was an error, I fixed this now and use dh_installchangelogs

> The manual page isn't that useful upstream, but they might be
> interested in it, with or without some changes.

I've sent it to upstream, if they want to use (but is not really
filled with "content", it only hints to the documentation).
> Lintian complaints:
> X: udav: spelling-error-in-binary ./usr/bin/udav usefull useful

If fixed that via quilt patch, and sent the patch also upstream.
Thanks for pointing to the --display-experimental of lintian.

I uploaded a new fixed version to mentors.debian.net
dget http://mentors.debian.net/debian/pool/main/u/udav/udav_0.5.1-1.dsc

Best regards

Attachment: signature.asc
Description: Digital signature

Reply to: