[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: fizmo (new package)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christoph Ender schrieb:
> 
> 
> Dear debian mentors,
> 
> I'm looking for a sponsor to upload my new package "fizmo". This is a
> Z-Machine
> interpreter, which may be used to play Infocom / Inform games. For
> screenshots
> and general information, please refer to
> http://spellbreaker.org/~chrender/fizmo/.
> 
> Name: fizmo
> License: BSD
> Fixes ITP bug number: 525490
> Description:
>  Fizmo is a Z-Machine interpreter ("Fizmo Interprets Z-Machine Opcodes")
> which
>  allows you to run Infocom- and most other Z-Machine based games -- except
>  version 6 -- on POSIX-like systems which provide a ncursesw (note the "w")
>  library. It has been successfully compiled on Debian based Linux, Mac OS X
>  (with MacPorts providing ncursesw) and Windows (using Cygwin and a self-
>  compiled ncursesw library). This is a "console"-style application,
> meaning that
>  it runs in textmode and does not provide any GUI whatsoever. About
> Infocom and
>  interactive fiction in general, see the "New to IF" section at
> http://www.ifarchive.org.
> 
> The package is available from:
>  - http://spellbreaker.org/~chrender/fizmo/deb-upstream/fizmo_0.6.2-1.dsc
>  -
> http://spellbreaker.org/~chrender/fizmo/deb-upstream/fizmo_0.6.2-1.diff.gz
>  -
> http://spellbreaker.org/~chrender/fizmo/deb-upstream/fizmo_0.6.2.orig.tar.gz
> 
> 
> lintian shows no warnings when run as "lintian -Ivi". For testing
> purposes, game files
> may be found at
> http://www.ifarchive.org/indexes/if-archiveXgamesXzcode.html
> It would be nice if someone would look into the package.

Hello,

I found following issues:

- - Out of date Standards-Version (current is 3.8.1).
- - You manual adding library dependencies to the package, you should use
${shlib:Depends} and while you are using debhelper also ${misc:Depends}
and drop those hardcoded depends, this is wrong.
- - You are continueing from the short to the long description, but the
long description is a single "field".
- - You could drop from debian/rules most outcommented stuff, so that it
is easier to read

Hmm the copying of the package also does not make me very happy.. an
"All rights reserved", no copyright headers in the source files, hmm

- --
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

E-Mail: pmatthaei@debian.org
        patrick@linux-dev.org

Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkny7+EACgkQ2XA5inpabMfUhwCgjmI7SX+Cr0lmvcOGeCtLhKFM
sBIAoKmReSuP5dlsgiPrWXqKKaUoWYOi
=8IHA
-----END PGP SIGNATURE-----


Reply to: