[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Lintian question

On Tue, Apr 21, 2009 at 04:54:12PM -0500, Charlie Smotherman wrote:
> W gz-file-not-gzip
> The file that lintian is complaining about is
> usr/share/ampache/www/modules/getid3/module.archive.gzip.php
> As you can see the file clearly does not end with .gz but instead it
> ends in php.  This file is not compressed with gzip but instead adds
> gzip functionality to the app.
> Is this a bug with Lintian as it is clearly reporting a false positive?

It's a false positive and should be reported as a bug, if there is not
one open for it already. The attached patch should fix it by only
matching filenames that end in the string .gz, not merely contain it.
You may add it to your bug if you wish, though lintian maintainers may
have a better way to fix it.

> Would an override of this Lintian warning be appropriate?

At your discretion a temporary override would make your package look
clean, but when the bug is fixed the warning will go away anyway and you
will have to upload again to remove the override. There's no harm in
just ignoring the warning.

Jonathan Wiltshire

PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3  A903 CA6B EA3E DB80 0B52
--- lintian-2.2.9/checks/files~	2009-04-21 23:40:26.000000000 +0100
+++ lintian-2.2.9/checks/files	2009-04-21 23:41:20.000000000 +0100
@@ -761,7 +761,7 @@
 	# ---------------- .gz files
-	if ($file =~ m/\.gz/) {
+	if ($file =~ m/\.gz$/) {
 	    my $info = $info->file_info->{$file} || '';
 	    if ($info !~ m/gzip compressed/) {
 		tag "gz-file-not-gzip", "$file";

Attachment: signature.asc
Description: Digital signature

Reply to: