Re: RFS: kio-ftps (updated package)
Hi, Laurent.
IANADD, but I just saw your package. And I have some comments.
On Apr 14 2009, Laurent Léonard wrote:
> It builds these binary packages:
> kio-ftps - an ftps KIO slave for KDE 4
>
> The package appears to be lintian clean.
* I'm not so sure about this:
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
I: kio-ftps source: quilt-patch-missing-description cmakelists_kde42_fix.diff
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
* The source tree has many *~ files there. Since you are modifying the
source package (removing the RFC file), you can remove those too, if
they aren't needed.
* The long description has lowercase letter starting sentences. This
should be fixed.
* Shouldn't the package has a versioning indicating that it was modified
from upstream, with a dfsg suffix?
Regards, Rogério Brito.
--
Rogério Brito : rbrito@{mackenzie,ime.usp}.br : GPG key 1024D/7C2CAEB8
http://www.ime.usp.br/~rbrito : http://meusite.mackenzie.com.br/rbrito
Projects: algorithms.berlios.de : lame.sf.net : vrms.alioth.debian.org
Reply to: