[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: qrupdate

On Thu, Jan 29, 2009 at 10:06 AM, Jordi Gutiérrez Hermoso
<jordigh@gmail.com> wrote:

> - dget http://mentors.debian.net/debian/pool/main/q/qrupdate/qrupdate_1.0-1.dsc

Some comments on just the diff.gz:

You should use a Debian-specific SONAME if upstream doesn't have one.
Please teach upstream about SONAMEs, ABI etc and get them to do that
stuff instead of doing it yourself.

debian/postinst & debian/postrm look like they can be removed and
generated by debhelper.

debian/substvars should not be in the diff.gz

patches/add-soname seems to change the whitespace in the definition of SRC, why?

patches/add-soname has a typo in one of the variables added: VERSIOON

patches/add-soname needs some more metadata: upstream status, author,
location it was taken from (if it was taken from somewhere).

you specify debhelper compat 7 but don't seem to use the features of
it (annoying for backports). Also, is perl 5.10 really needed?

you should definitely ask upstream to implement make install.

you might want to send the function-reference script upstream along
with a patch to integrate it with their build process.

There is some extra whitespace:

tab character before the Source: package name in debian/control

extra lines in debian/watch debian/*dirs debian/*install debian/docs



Reply to: