Hi!
[...]
>
> I'll grab the package from mentors.d.n later on this weekend and report back.
>
Sorry that it took so long, but now I got around to do another round of review.
- The unpacked source contains dhcp-probe.debhelper.log
- control/Description has some strange whitespace, please clean up.
- You don't need a Pre-Depends on ucf, Depends should be sufficient (you use it
in the postinst, there is no preinst here)
- What about the upstream status of your patch?
- debian/rules:
* You don't use the DEST variable, please remove it.
* In the clean target, run dh_clean ... after dh_auto_clean; this will resolve
the above dhcp-probe.debhelper.log issue
I think these issues should be easy to resolve, and other than that the package
looks fine to me.
Best,
Michael
Attachment:
pgp6TzhT0qYC1.pgp
Description: PGP signature