Re: RFS: liboauth-php
Hi Daniel,
Daniel Watkins wrote:
>
> On Mon, 18 Aug 2008 12:01:16 -0500
> Raphael Geissert <atomo64+debian@gmail.com> wrote:
>
>> > Upstream Author : Andy Smith <andy@anarkystic.com>
>> .
>> > * License : MIT
>>
>> Oh really? none of the files shipped by upstream say a thing about
>> authorship nor licence nor copyright. And a quick look at the website
>> doesn't help either.
>>
>> Where did you get that information from?
> The Google Code page lists it. However, I've contacted the author and
> he's added a LICENSE.txt file.
Ok, nice.
Just one extra note on the copyright file:
> The Debian packaging is (C) 2008, Daniel Watkins
<daniel@daniel-watkins.co.uk>
> and is licensed under the GPL, see `/usr/share/common-licenses/GPL'
If upstream is releasing its work under the MIT licence you should consider
also licencing your Debian packaging under the terms of the MIT licence
too, as it may cause you troubles when adding patches because of licence
conflicts.
But if you still want to release your packaging under the GPL then please
specify which version and add an exception (more info at www.gnu.org)
Oh, and just noticed on the changelog:
> * Added LICENSE.txt file with MIT license, copyright owner is perhaps
> dubious however.
Could you please clarify (or request upstream to clarify)?.
>
>> debian/control:
>> Depends: php4 | php5, ${shlibs:Depends}, ${misc:Depends}
>>
>> php4 is obsolete and won't be shipped neither in lenny nor lenny+1,
>> so the ORed dependency is useless (and in any case php5 should be the
>> first to appear).
> Fixed.
Forgot to mention something, if there is any chance (i.e. a corner case)
where somebody may want to use this lib on a script being run with php5-cli
then make it an ORed dependency, e.g. php5 | php5-cli
The php5 meta-package only makes sure any of the web server interpreters is
installed, which excludes -cli.
>
>> Oh, and from lintian:
>> I: liboauth-php source: debian-watch-file-is-missing
> As this is using upstream's SVN, uscan can't do much. I've added a
> debian/watch with comments explaining this.
I'm planning to add support for checking $VCS' with uscan, but on the
meanwhile addding comments is enough (well, some please make use of
upstream $VCS branches, but I don't see any on your case).
debian/docs: 'example'
You should better use dh_installexamples (read its doc for more information
on how to make dh do all the job), as it will install it in examples/.
Ok, besides that...:
> liboauth-php_0~svn622-1_all.deb
> -------------------------------
> new debian package, version 2.0.
> size 14996 bytes: control archive= 1024 bytes.
> 706 bytes, 16 lines control
> 938 bytes, 12 lines md5sums
> Package: liboauth-php
> Version: 0~svn622-1
> Architecture: all
> Maintainer: Daniel Watkins <daniel@daniel-watkins.co.uk>
> Installed-Size: 104
> Depends: php5
> Section: web
> Priority: optional
> Homepage: http://oauth.net/
> Description: PHP library implementing the OAuth secure authentication
protocol
> OAuth is a simple way to publish and interact with protected data. It
allows
> the User to grant access to their private resources on one site (the
Service
> Provider), to another site (the Consumer, not to be confused with the
User).
> While OpenID is all about using a single identity to sign into many
sites,
> OAuth is about giving access to your stuff without sharing your identity
at all
> (or its secret parts).
After reading the description several times I still don't get why all the
text inside the parenthesis is needed (with the sole exception being the
last one). What about rephrasing or rechecking the description?
> drwxr-xr-x root/root 0 2008-08-22 20:17 ./
> drwxr-xr-x root/root 0 2008-08-22 20:17 ./usr/
> drwxr-xr-x root/root 0 2008-08-22 20:17 ./usr/share/
> drwxr-xr-x root/root 0 2008-08-22 20:17 ./usr/share/php/
> drwxr-xr-x root/root 0 2008-08-22 20:17 ./usr/share/php/oauth/
> -rw-r--r-- root/root 22342 2008-08-18
14:48 ./usr/share/php/oauth/OAuth.php
> -rw-r--r-- root/root 3826 2008-08-18
14:48 ./usr/share/php/oauth/OAuth_TestServer.php
I fail to see how that file can be useful under /usr/share/php, what about
placing it under examples/?
> drwxr-xr-x root/root 0 2008-08-22 20:17 ./usr/share/doc/
> drwxr-xr-x root/root 0 2008-08-22
20:17 ./usr/share/doc/liboauth-php/
> -rw-r--r-- root/root 1523 2008-08-22
19:53 ./usr/share/doc/liboauth-php/copyright
> -rw-r--r-- root/root 407 2008-08-18
14:48 ./usr/share/doc/liboauth-php/changelog.gz
> -rw-r--r-- root/root 166 2008-08-22
19:53 ./usr/share/doc/liboauth-php/changelog.Debian.gz
> drwxr-xr-x root/root 0 2008-08-22
20:17 ./usr/share/doc/liboauth-php/example/
> -rw-r--r-- root/root 1695 2008-08-18
14:48 ./usr/share/doc/liboauth-php/example/client.php.gz
> -rw-r--r-- root/root 490 2008-08-18
14:48 ./usr/share/doc/liboauth-php/example/echo_api.php
> -rw-r--r-- root/root 256 2008-08-18
14:48 ./usr/share/doc/liboauth-php/example/request_token.php
> -rw-r--r-- root/root 255 2008-08-18
14:48 ./usr/share/doc/liboauth-php/example/access_token.php
> -rw-r--r-- root/root 3910 2008-08-18
14:48 ./usr/share/doc/liboauth-php/example/index.php
> -rw-r--r-- root/root 672 2008-08-18
14:48 ./usr/share/doc/liboauth-php/example/common.inc.php
> -rw-r--r-- root/root 2682 2008-08-18
14:48 ./usr/share/doc/liboauth-php/design.txt
>
>
Cheers,
--
Atomo64 - Raphael
Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
Reply to: