[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libgpiv, gpiv and gpivtools (2nd try)



OoO  En cette  matinée ensoleillée  du lundi  26 mai  2008,  vers 09:46,
Gerber van der Graaf <gerber.vdgraaf@gmail.com> disait:

> Package: libgpiv-0.5.2

Hi Gerber!

Your debian/changelog  is quite  unusual. While this  is allowed,  it is
more usual to have blank line after first line and blank one before last
one:

libgpiv (0.3.3-1) unstable; urgency=low

  * Initial Release. Closes: #354150

 -- Gerber van der Graaf <gerber_graaf@users.sourceforge.net>  Wed, 22 Mar 2006 20:39:27 +0100

debian/conffiles.1  is  not  needed  anymore.  Moreover,  I  think  that
"conffiles.1"  is not  a valid  file at  all. Just  remove it.  Same for
rules.1.

Your description  in debian/control is  quite dense. Add blank  lines in
the long description.  Moreover, remove the capital on  the first letter
of  the short  description: "library  for...".  You also  might want  to
provide a -dbg library. Look at dh_strip which is able to most steps for
you.

In debian/copyright,  you should copy  paste the complete  disclaimer at
the top of each file:
   Libgpiv is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 2, or (at your option)
   any later version.

For  example, you forgot  to say  that this  software is  licensed under
GPLv2 or later.

You  are   using  dh_movefiles.  This  is   deprecated.  Use  dh_install
instead.  The manual  page states  how to  migrate from  dh_movefiles to
dh_install.

You can shorten a bit debian/rules:
 + CFLAGS and INSTALL_PROGRAM settings  can be removed, this is now done
   automatically
 + you  can remove  the block from  "shared library versions"  to latest
   "awk": you don't use those variables

You can also update the snippet to update config.sub and config.guess:

ifneq "$(wildcard /usr/share/misc/config.sub)" ""
        cp -f /usr/share/misc/config.sub config.sub
endif
ifneq "$(wildcard /usr/share/misc/config.guess)" ""
        cp -f /usr/share/misc/config.guess config.guess
endif

> Package: gpiv-0.5.2

I will look at it later.
-- 
I WILL NOT DO THE DIRTY BIRD
I WILL NOT DO THE DIRTY BIRD
I WILL NOT DO THE DIRTY BIRD
-+- Bart Simpson on chalkboard in episode AABF08

Attachment: pgptivoMdd53X.pgp
Description: PGP signature


Reply to: