[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: monkey (updated package)



On Mon, Nov 24, 2008 at 4:51 PM, Thorsten Schmale
<thorsten@schmalenegger.com> wrote:

> http://mentors.debian.net/debian/pool/main/m/monkey/monkey_0.9.2-4.dsc

Firstly, please do not send HTML mail:

http://www.debian.org/MailingLists/#codeofconduct

You should not modify the changelog entries of versions that have
already been uploaded to the archive.

This version adds the following files outside the debian/ directory, why?

monkey-0.9.2/bin/banana
monkey-0.9.2/conf/monkey.conf
monkey-0.9.2/conf/monkey.deny
monkey-0.9.2/src/include/info.h
monkey-0.9.2/src/Makefile
monkey-0.9.2/Makefile

You should include a Homepage field.

Why the blank line at the end of the package description?

Please send your manual page, default configuration file and possibly
init script upstream if you haven't already.

Why do you run ./configure twice in debian/rules?

The watch file does not work - gives 403 Forbidden. Perhaps you could
educate upstream about using the sf.net file release system so their
get the benefit of local mirrors and you can use the magical uscan
support for sf.net?

You should target experimental during the freeze or contact the
release team for getting -3 into testing and pre-approval for -4.

Your package has no debtags, please add some:

http://debtags.alioth.debian.org/edit.html?pkg=monkey

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


Reply to: