Re: RFS: esekeyd (3rd try)
2008/11/15 Sandro Tosi <matrixhasu@gmail.com>:
> debian/compat:
> - please use a more up-to-date debhelper (either 5 or 7 is fine), 4 is
> a little old nowdays :)
Changed to 7.
> - uncapitalize short description: "multime..."
Done.
> - every 2.6 kernel is enough? if not, please clearly state it in the
> description
Any 2.6 is OK.
> debian/copyright:
> - please use a more precise template like this:
[...]
> - for GPLv2+. it's better to link to /usr/share/common-licenses/GPL-2
> - mh: you claim it's GPLv2+ but the COPYING files is GPLv3+? may you
> please clarify a bit?
Update debian/copyright to GPLv3.
> - please clearly state what's the debian/* copyright+license, and it's
> usually better to have the same license of the upstream code (pretty
> here here :) )
Changed to GPLv3 everywhere.
> - please list all the copyright holder for any file shipped, for
> example debian/esekeyd.init has even jfs as holder, and it's missing
> in debian/copyright
Done.
> - and even for every file shipped in the source tarball, like
> ./src/esekeyd.c has different copyright notices, or for file with
> different copyright years than the one you stated in this file, like
> ./src/input.c (and this file even miss a clear license). I use this
> command 'find . -type f -exec less {} \;' in the top level dir to
> check every file: please list all the files differing from the main
> copyright holder + license (and extend your copyright years as in the
> file in the tarball)
Done.
> debian/watch:
> - well, maybe it's not so useful this time, but I like to see a watch
> file: it's very easy to add it, and it completes the package
Done.
> debian/rules:
> - when touching stamp file, use 'touch $@'
> - no need to call dh_clean in install target (moreover, -k option is deprecated)
> - merge 'rm -f' into dh_clean
> - mh, about copying /usr/share/misc/config.sub, why are you copying
> them in clean target and not in configure? maybe autotools-dev does
> the magic, but it seems strange to me
All done. Copy of fresh config.{sub,guess} are made in configure and
removed in clean target.
> In case of any question, just ask :) and get back to me once you
> prepared the updated package (same revision for me, thanks). Thanks
> for the work done so far.
Updated version was uploaded to mentors.d.n.
Thanks for review,
--
Krzysztof Burghardt <krzysztof@burghardt.pl>
http://www.burghardt.pl/
Reply to: