Re: RFS: vbackup

[Stefanos Harhalakis <v13@v13.gr>]

Hello Vincent,

On Thursday 04 September 2008, Vincent Bernat wrote:
> OoO Lors  de la soirée naissante  du dimanche 31 août  2008, vers 18:40,
>
> Stefanos Harhalakis <v13@v13.gr> disait :
> >> You should also correct those lintian warnings:
> >> I: vbackup: hyphen-used-as-minus-sign usr/share/man/man8/vbackup.8.gz:32
> >> W: vbackup: doc-base-unknown-section vbackup:6 admin
> >
> > I believe that they are fixed since "lintian -I" doesn't produce any
> > errors/warnings/infos and mentors.debian.net says the same thing.
>
> I still get them:
> I: vbackup: hyphen-used-as-minus-sign usr/share/man/man8/vbackup.8.gz:114
> I: vbackup: hyphen-used-as-minus-sign usr/share/man/man8/vbackup.8.gz:120
> W: vbackup: doc-base-unknown-section vbackup:6 Administration
>
> For the last one, you should use System/Administration.
>
> Makefile.in is still  modified in diff.gz. This is  not really important
> but this is better to correct this too.

I fixed them all in the debian package and added the man page fix 
to "upstream" too for the next release. I've also removed the Makefile.in 
modifications, config.sub, config.guess and the following lines from 
debian/rules:

ifneq "$(wildcard /usr/share/misc/config.sub)" ""
        cp -f /usr/share/misc/config.sub config.sub
endif
ifneq "$(wildcard /usr/share/misc/config.guess)" ""
        cp -f /usr/share/misc/config.guess config.guess
endif

correct?

I also have a question. Should I change anything else in debian/rules to 
indicate that this is not an architecture dependend package? I don't like 
seeing the file: vbackup_0.1.6-2_i386.changes (why i386 and not all?). 
Everything is listed as binary-indep but should I also modify the configure 
line to remove --host, --build, CFLAGS and LDFLAGS?

Currently it says:

DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
    --prefix=/usr --mandir=\$${prefix}/share/man \
    --infodir=\$${prefix}/share/info CFLAGS="$(CFLAGS)" \
    LDFLAGS="-Wl,-z,defs" --sysconfdir=/etc

The latest version (-2) is available in mentors.

Thanks!