[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: winff



OoO En ce  début d'après-midi ensoleillé du dimanche  10 août 2008, vers
15:15, Paul Gevers <paul@climbing.nl> disait :

> I know I should be patient and that Lenny recently has been frozen, but
> this is my first package for Debian and I would appreciate some feedback
> on how I have done after a month waiting. I therefore take the liberty
> to send this mail with my request for comments (or of course sponsorship).

> For completeness I have added the full description of the winff package
> this time.

Hi Paul!

There are only very minor problems with your package:
 - You don't  need to  include  README.Debian in  debian/docs. This  is
   included automatically.
 - You don't need debian/postinst, debian/postrm, they are automatically
   generated by dh_installmenu and dh_installdocs.

You can also correct this lintian warning:

I: winff: desktop-entry-contains-encoding-key /usr/share/applications/winff.desktop:3 Encoding
N:
N:   The Encoding key is now deprecated by the FreeDesktop standard and all
N:   strings are required to be encoded in UTF-8. This desktop entry
N:   explicitly specifies an Encoding of UTF-8, which is harmless but no
N:   longer necessary.
N:   
N:   Refer to
N:   http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html for
N:   details.

The package seems fine otherwise. This is really good for a first package.
-- 
les seuls qui lisent les FAQs sont ceux qui savent déjà ce qu'il
 y a dedans.
 -+- AT in: Guide du Cabaliste Usenet - chapitre 4 -+-

Attachment: pgpZ6qYUkku7E.pgp
Description: PGP signature


Reply to: