Re: RFS: xtod

[Patrick Matthäi <patrick.matthaei@web.de>]

Stefan Ritter schrieb:
> Dear mentors,
> 
> 
> The package appears to be lintian clean.
> 

Here not:
W: xtod: binary-without-manpage usr/games/xtod
W: xtod source: out-of-date-standards-version 3.7.3 (current is 3.8.0)


Hello,

I think I'll just begin :)

 * Any reason why it's an native package? I can't see anyone.
 * I think it will build fine on more architectures than on i386.
 * There are some useless whitespaces at EOL: $ grep -r \ $ *|wc -l => 5
 * .. also newlines at EOF.
 * To minimize the debian/rules you should remove outcommented
debhelpers and some other template lines.
 * debian/dirs is in this case useless, the install target creates them.
 * s/Copyright/Copyright:/ in debian/copyright
 * It's better to include the point of the full GPL text after the GPL
header of the xtod package in debian/copyright.
 * An extra whitespace in the short description?
 * Okay that's hard to do.. Could you provide a more describtive
long-desc? :)

Okay enough for the first review :)

-- 
Mit freundlichem Gruß / With kind regards,
Patrick Matthäi

E-Mail: patrick.matthaei@web.de