[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: arping (updated package - ITA)



Giuseppe Iuculano <giuseppe@iuculano.it> (22/06/2008):
> Ok :)

Thanks. :)

> > Shouldn't it be 2.07~pre1-1, so that you can version the real release as
> Fixed, thanks.

You then need to use version mangling in your debian/watch file. Check
for dversionmangle in uscan(1). BTW, you're still using “version=2”
while current version is 3.

> Thanks a lot.

No need to thank before you get the review. Here it goes:

debian/changelog:
 - You close #210992 in the “New upstream release” entry. While this is
   strictly speaking correct, it might be nice to specify that this
   isn't just closing a “please package new upstream release” bug, but a
   “real” bug. You might use something like:
|  * New upstream release. libnet is now initialized correctly, which fixes
|    the segmentation fault on imbecile user input (Closes: #210992).

 - You might want to thank the previous maintainer for his former
   contribution in your “closing ITA” entry, but that's really your
   call. :)

 - You rewrote debian/rules. OK. But that'd be nice to say why it fixes
   #436472 (e.g. “now handles nostrip build option”).

 - When you added the debhelper compat level, did you make sure that
   nothing had to be adapted from the previous behaviour, as it's
   documented in “Debhelper compatibility levels” from debhelper(7)? I
   know arping is quite a tiny package, but still, there could be some
   surprizes.

 - Did you forward the manpage fix upstream? While you're at it, there's
   another one to fix (with some occurrences), namely:
   I: arping: hyphen-used-as-minus-sign usr/share/man/man8/arping.8.gz
   You have to run lintian with e.g. -iI to have it displayed, as it's
   only an I:, not a W: or E:.

 - You could add your address in debian/copyright, 3rd line. You could
   also use © instead of (C). The following would be sufficient:
   “Copyright: © 2000-2003 Thomas Habets <thomas@habets.pp.se>”
   You could ask upstream to add license headers to *.h, and probably to
   update the copyright years in arping-2/arping.c at least. And while
   we're at it, the FSF address is outdated. (licensecheck -r . is your
   friend, by the way.) Ah, and you may also want to specify a license
   for the Debian packaging. Usually, “The Debian packaging is licensed
   under the same terms and is: © $years $you” is seen.

 - During the build, I've noticed the -I targeting /usr/local. I guess
   it could possibly break the build under some circumstances (when
   having incompatible versions of the libraries under /usr/local), so
   you may want to strip those locations from the -I/-L flags.

I think that's all for now. :)

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: