Re: RFS: vidalia
Vern Sun wrote:
> That's great. Updated from version 1.0.2-2~b2 to 1.0.2-2.
I've had a look and it mostly looks good.
However, as Ansgar said, you have misused the Vcs-* field.
Also, your debian/changelog has all of the upstream changelog in it. This is
incorrect, debian/changelog is the changelog for the *packaging*. The
upstream changelog is already available in the CHANGELOG file so you don't
need to repeat it. You just need a single entry stating this is the first
Debian package and detailing any changes from upstream that you needed to make.
I'm also getting the following lintian warning:
W: vidalia: postinst-does-not-load-confmodule
N:
N: Even if your postinst does not involve debconf, you currently need to
N: make sure it loads one of the debconf libraries. This will be changed
N: in the future.
Finally, this is the first ever Debian package for vidalia so it should have
a Debian version of -1. Unfortunately I don't think mentors will let you
upload a -1 now that you've uploaded a -2 which is unfortunate. If you have
some webspace that you could upload a new -1 package to then please do that
and let us know the URL. Having -1 as the first real Debian version means
that the orig.tar.gz gets automatically uploaded too and so makes the
sponsors job easier.
regards,
Colin
--
Colin Tuckley | +44(0)1903 236872 | PGP/GnuPG Key Id
Debian Developer | +44(0)7799 143369 | 0x1B3045CE
"Heisenberg may have slept here"
Reply to: