> > > Looks like this in the upstream makefile:
> > >
> > > all allbin alldoc tags clean:
> > > @for I in ${subdirs}; do (cd $$I; ${MAKE} $@ || exit 1); done
> > >
> > > Should be replaced with this:
> > >
> > > all allbin alldoc tags clean:
> > > @for I in ${subdirs}; do (cd $$I; ${MAKE} $@) || exit 1; done
> > >
> > > Same for the other targets in the Makefile.in that have a similar construct.
> >
> > Indeed. Thanks for pointing out.
>
> Done in upstream CVS.
Good job. I just update the source from CVS and test it, look fine.
> So, libxt-dev build-dep should not be required in next
> upstream version.
:P Actually, already removed by my mistake for the last upload.
When do you plan to release the new release ?
in the meantime I'm searching the informations for the security issue
about the setuid/setgid which this package done, for now I found the
security audit tools which I can do the basically tests.
But I still don't know how to contact the security team
(mailing-list? I just subscribe but never recieve any mails,
is it still active?)
and how to beg them to review my package.
Best Regards,
Neutron Soutmun
เมื่อ ส. 2008-04-19 เวลา 20:30 +0700, Theppitak Karoonboonyanan เขียน
ว่า:
> On Thu, Apr 17, 2008 at 11:27 AM, Theppitak Karoonboonyanan
> <thep@linux.thai.net> wrote:
> > On Thu, Apr 17, 2008 at 10:34 AM, Paul Wise <pabs@debian.org> wrote:
> > > Looks like this in the upstream makefile:
> > >
> > > all allbin alldoc tags clean:
> > > @for I in ${subdirs}; do (cd $$I; ${MAKE} $@ || exit 1); done
> > >
> > > Should be replaced with this:
> > >
> > > all allbin alldoc tags clean:
> > > @for I in ${subdirs}; do (cd $$I; ${MAKE} $@) || exit 1; done
> > >
> > > Same for the other targets in the Makefile.in that have a similar construct.
> >
> > Indeed. Thanks for pointing out.
>
> Done in upstream CVS.
>
> > For the Xt dependency, it was missed during libSM and libICE removal.
> > Indeed, xt needs to be checked in the configure script, in addition to x11.
> > And hopefully, -Wl,--as-needed can prevent libSM and libICE from being
> > pulled in along with libxt again.
>
> Dependency on X11/Intrinsic.h has been eliminated instead
> in upstream CVS.
>
> In fact, it's doubtable that the build only required the
> header file, but not the library linkage. That means no
> symbols were called, only data types or macros were used.
> And fortunately, all can be expressed in terms of pure Xlib.
>
> So, libxt-dev build-dep should not be required in next
> upstream version.
>
> Regards,
> --
> Theppitak Karoonboonyanan
> http://linux.thai.net/~thep/
>
>
Attachment:
signature.asc
Description: =?UTF-8?Q?=E0=B8=99=E0=B8=B5=E0=B9=88=E0=B8=84=E0=B8=B7=E0=B8=AD?= =?UTF-8?Q?=E0=B8=AA=E0=B9=88=E0=B8=A7=E0=B8=99=E0=B8=82=E0=B9=89?= =?UTF-8?Q?=E0=B8=AD=E0=B8=84=E0=B8=A7=E0=B8=B2=E0=B8=A1=E0=B8=97?= =?UTF-8?Q?=E0=B8=B5=E0=B9=88=E0=B8=A1=E0=B8=B5=E0=B8=A5=E0=B8=B2?= =?UTF-8?Q?=E0=B8=A2=E0=B9=80=E0=B8=8B=E0=B9=87=E0=B8=99=E0=B8=94?= =?UTF-8?Q?=E0=B8=B4=E0=B8=88=E0=B8=B4=E0=B8=97=E0=B8=B1=E0=B8=A5?= =?UTF-8?Q?=E0=B8=81=E0=B8=B3=E0=B8=81=E0=B8=B1=E0=B8=9A?=