[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: QA Upload - muine 0.8.8-1 - Simple playlist based music player

Neil Williams wrote:
On Wed, 20 Feb 2008 11:21:10 -0500
Barry deFreese <bddebian@comcast.net> wrote:

from changelog:
* Remove -X revisions on build-depends.
Huh? I can see that removing -1 is most often a good idea, but -3?

It was my understanding that build-depending on any Debian revision was a bad idea?

Not necessarily. A library could well have a serious bug that is fixed
in Debian before being fixed upstream and the program may need the
fixed version. e.g. an unintended API breakage can be reverted. In that
case, 1.2.3-1 is borked but 1.2.3-2 is fine (as is 1.2.2-8 and,
hopefully, 1.2.4-1). Other candidates can be broken pkgconfig files,
out of date autotools stuff, transitions in build tools
themselves . . .
Generally, though, Build-Depends versions come directly from whatever
build system is used upstream (and can be omitted completely if Debian
does not have anything older than the minimum required version
specified in the build system - that includes testing, stable and
oldstable so is quite rare).

Why would -3 be any better than -1? There shouldn't be any API/ABI changes between Debian revisions should there?

Should be - no. Can be - yes, usually trying to fix a mistake upstream.

Obviously, I guess it makes sense if there was some specific bug fix but it still seems like a bad idea, but what do I know? :)

Unless there is a *specific* reason for the Debian revision to be
included, it should be omitted. Packages that do include the revision
should not be assumed to be buggy merely due to the presence of such a
revision although it is sensible to check that the revision is
actually necessary.
OK, I have put back the -3 build-dep and left the -1 removed. Also, I have talked to some mono folks and the warnings on dh_makeclideps is OK. I've added foo.dll.config files to handle it but the warnings still exist. I'm told this is OK.

If anyone has time to review and/or upload I would appreciate it.



Barry deFreese

Reply to: