[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: avant-window-navigator 0.2.1



Julien Lavergne scrisse:

> Dear mentors,
> I am looking for a sponsor for my package "avant-window-navigator". 

I did a review of your package, and spotted these issues:

* It looks like you're shipping a non DFSG-free icon,
  data/avant-window-navigator.svg under CC 2.0 by-sa, as specified by
  its rdf metadata. Please contact upstream and ask him to relicense it
  under a free one (ie. upgrade to CC 3.0). Please mention it in
  debian/copyright too.

* I can't understand what /usr/lib/awn/applets/taskman.desktop stand
  for. I've never seen a launcher under /usr/lib/ and without a exec
  line. And it resides in avant-window-navigator binary package.
  What's its purpose?

* You should probably ask debian-l10n-en to proofread your descriptions.
  I'm not a native speaker, but they sound a bit strange to.
  I'd suggest at least to rework brief descriptions and fix the
  spelling: 

awn-manager - A preferences manager for avant-window-navigator
libawn-dev - library for avant-window-navigator - development files
python-libawn0 - Python bindings for avant-window-navigator library 

The rest of the package seems goods to me, but first point has to be
resolved. 
Moreover, I'm not very confident with cdbs, and I hope
someone more used to it would do a deeper review of that part of your
package.

> Kind regards
>  Julien Lavergne

Thanks for your contribution,
Ciao, Luca

-- 
 .''`.  ** Debian GNU/Linux **  | Luca Bruno
: :'  :   The Universal O.S.    | lucab (AT) debian.org
`. `'`  			| GPG Key ID: 3BFB9FB3
  `-     http://www.debian.org 	| Debian GNU/Linux Developer

Attachment: pgpMZT5KT22zT.pgp
Description: PGP signature


Reply to: