[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: Thousand Parsec packages.



Hi

On Tue, 29 Jan 2008 23:25:53 -0500
Barry deFreese <bddebian@comcast.net> wrote:

> Could someone please review my thousand parsec packages on mentors?  
> Upstream is begging me to get packages out there.  I sent this to the 
> games team a while back but received no response so I'm hoping someone 
> on mentors will take pity on me. :-)

Do you know tool called lintian?

> http://mentors.debian.net/debian/pool/main/l/libtpproto-py/libtpproto-py_0.2.2-1.dsc 

$ lintian -I libtpproto-py_0.2.2-1_i386.changes 
I: libtpproto-py source: build-depends-without-arch-dep python-all-dev
W: python-tp-netlib: new-package-should-close-itp-bug

- Some description what Thousand Parsec is in description would be nice.
- "Work in progress.." in changelog?
- No need to byte compile python modules, use --no-compile

> http://mentors.debian.net/debian/pool/main/l/libtpclient-py/libtpclient-py_0.2.2-1.dsc 

$ lintian -I libtpclient-py_0.2.2-1_i386.changes
I: libtpclient-py source: build-depends-without-arch-dep python-all-dev
W: python-tp-clientlib:
script-not-executable ./usr/share/python-support/python-tp-clientlib/tp/client/pyscheme/all_tests.py
W: python-tp-clientlib:
script-not-executable ./usr/share/python-support/python-tp-clientlib/tp/client/pyscheme/scheme.py
W: python-tp-clientlib:
script-not-executable ./usr/share/python-support/python-tp-clientlib/tp/client/pyscheme/test_scheme.py
W: python-tp-clientlib: new-package-should-close-itp-bug

- Some description what Thousand Parsec is in description would be nice.
- "Work in progress.." in changelog?
- No need to byte compile python modules, use --no-compile

> http://mentors.debian.net/debian/pool/main/t/tpclient-pywx/tpclient-pywx_0.2.2-1.dsc 

$ lintian -I tpclient-pywx_0.2.2-1_i386.changes
E: tpclient-pywx_0.2.2-1_i386.changes: bad-distribution-in-changes-file
UNRELEASED W: tpclient-pywx: binary-without-manpage
usr/games/tpclient-pywx W: tpclient-pywx:
script-not-executable ./usr/share/games/tpclient-pywx/doc/tp-pywx-installed
W: tpclient-pywx:
script-not-executable ./usr/share/games/tpclient-pywx/extra/wxFloatCanvas/FloatCanvas.py
W: tpclient-pywx: new-package-should-close-itp-bug

- XS-Python-Version and debian/version IMHO should not be different
- debian/dirs is not needed
- Some description what Thousand Parsec is in description would be nice.
- "Work in progress.." in changelog?

> On of the big things I need to know about are the copyright files.  
> Upstream doesn't specify any years for Copyright that I can find.

Didn't get to copyright files at all for now ;-).

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Attachment: signature.asc
Description: PGP signature


Reply to: