[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libcares



On Nov 23, 2007 7:10 PM, Robin Cornelius <robin.cornelius@gmail.com> wrote:

> So it think that is now all the issues you raised with the package dealt with.

Some minor issues (only the first is a show-stopper):

inet_ntop.c isn't under the MIT licence as debian/copyright suggests.

Change:

/---
 Development header files and libs for developing programmes that
 use libcares1 an Asynchronous resolver library.
...
 libcares is a C library that performs DNS requests and name resolves
\---

To:

/---
 Development header files and libs for developing programs that
 use libcares, an Asynchronous resolver library.
...
 libcares is a C library that performs DNS requests and resolves names
\---

I'm not sure that the libcares2 conflict on libares2 (which doesn't
exist) is necessary?? I think that only the libcares-dev conflict on
libares-dev is needed.

Please investigate this warning from the newest dpkg-dev and follow up upstream:

...
 cc -DHAVE_CONFIG_H -I. -I. -I. -g -Wall -O2 -c ares_llist.c -o
ares_llist.o >/dev/null 2>&1
/bin/sh ./libtool --tag=CC --mode=link cc  -g -Wall -O2   -o
libcares.la -rpath /usr/lib  -version-info 2:0:0 ares_fds.lo
ares_getsock.lo ares_process.lo ares_free_hostent.lo ares_query.lo
ares__close_sockets.lo ares_free_string.lo ares_search.lo
ares__get_hostent.lo ares_gethostbyaddr.lo ares_send.lo
ares__read_line.lo ares_gethostbyname.lo ares_strerror.lo
ares_cancel.lo ares_init.lo ares_timeout.lo ares_destroy.lo
ares_mkquery.lo ares_version.lo ares_expand_name.lo
ares_parse_a_reply.lo windows_port.lo ares_expand_string.lo
ares_parse_ptr_reply.lo ares_parse_aaaa_reply.lo ares_getnameinfo.lo
inet_net_pton.lo bitncmp.lo inet_ntop.lo ares_parse_ns_reply.lo
ares_llist.lo   -ldl
cc -shared  .libs/ares_fds.o .libs/ares_getsock.o .libs/ares_process.o
.libs/ares_free_hostent.o .libs/ares_query.o
.libs/ares__close_sockets.o .libs/ares_free_string.o
.libs/ares_search.o .libs/ares__get_hostent.o
.libs/ares_gethostbyaddr.o .libs/ares_send.o .libs/ares__read_line.o
.libs/ares_gethostbyname.o .libs/ares_strerror.o .libs/ares_cancel.o
.libs/ares_init.o .libs/ares_timeout.o .libs/ares_destroy.o
.libs/ares_mkquery.o .libs/ares_version.o .libs/ares_expand_name.o
.libs/ares_parse_a_reply.o .libs/windows_port.o
.libs/ares_expand_string.o .libs/ares_parse_ptr_reply.o
.libs/ares_parse_aaaa_reply.o .libs/ares_getnameinfo.o
.libs/inet_net_pton.o .libs/bitncmp.o .libs/inet_ntop.o
.libs/ares_parse_ns_reply.o .libs/ares_llist.o  -ldl  -Wl,-soname
-Wl,libcares.so.2 -o .libs/libcares.so.2.0.0
...
dpkg-shlibdeps: warning: debian/libcares2/usr/lib/libcares.so.2.0.0
shouldn't be linked with libdl.so.2 (it uses none of its symbols).

It probably has something to do with
http://wiki.debian.org/Projects/ImprovedDpkgShlibdeps

Not sure how often upstream adds new symbols, but you may want to
consider looking at the new symbols files stuff that the new dpkg-dev
allows.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



Reply to: